Repository navigation
share userfile over existing botlink - #1631
Open
michaelortmann wants to merge 7 commits into
Open
michaelortmann wants to merge 7 commits into
michaelortmann wants to merge 7 commits into
Conversation
michaelortmann
force-pushed
the
share.multiplex
branch
from
June 25, 2024 05:56
796e889 to
845d443
Compare
michaelortmann
force-pushed
the
share.multiplex
branch
from
June 26, 2024 23:09
0c64610 to
9736701
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Found by: michaelortmann
Patch by: michaelortmann
Fixes: #283
One-line summary:
share userfile over existing botlink
Additional description (if needed):
Please give feedback, then i will cleanup remaining debug output
Current implementation of userfile sharing opens an additional tcp connection
This PoC shares it via already existing botlink
This should be more robust and faster.
Test cases demonstrating functionality (if applicable):
On BotA and BotB, 2 share bots:
.console +*On BotB:
.link BotALog BotA:
Log BotB: