Skip to content

add ff_siwis - #21

Open
voldemortensen wants to merge 1 commit into
eduardolat:mainfrom
voldemortensen:main
Open

add ff_siwis#21
voldemortensen wants to merge 1 commit into
eduardolat:mainfrom
voldemortensen:main

Conversation

@voldemortensen

@voldemortensen voldemortensen commented Aug 8, 2026

Copy link
Copy Markdown

I have tested this locally and it works for me.

Fixes #12

Summary by CodeRabbit

  • New Features
    • Added French as an available language.
    • Added the French female voice “Siwis” for French text-to-speech.

@coderabbitai

coderabbitai Bot commented Aug 8, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: d48e0f9d-9d1e-4a34-8f95-21686c7fc574

📥 Commits

Reviewing files that changed from the base of the PR and between 2cb9d77 and 9da90f6.

📒 Files selected for processing (2)
  • src/lib/shared/resources/langs.ts
  • src/lib/shared/resources/voices.ts

📝 Walkthrough

Walkthrough

The resource catalogs now include French (fr-fr) and the female ff_siwis voice. Derived language and voice types include the new entries.

Changes

French voice support

Layer / File(s) Summary
French language catalog
src/lib/shared/resources/langs.ts
The exported langs list includes the fr-fr French language entry.
ff_siwis voice registration
src/lib/shared/resources/voices.ts
The voice resources map fr-fr and register ff_siwis with French metadata, female gender, target quality B, and overall grade B-.

Estimated code review effort: 1 (Trivial) | ~3 minutes

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly identifies the main change by naming the added ff_siwis voice.
Linked Issues check ✅ Passed The pull request adds the requested ff_siwis French voice and its required French language registration for issue #12.
Out of Scope Changes check ✅ Passed The changes are limited to registering the French language and the requested ff_siwis voice.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@voldemortensen voldemortensen mentioned this pull request Aug 8, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

ff_siwis voice

1 participant