sets: drop redundant OVMF-SNP/TDX inherits from node-installer-image#2336
Open
sets: drop redundant OVMF-SNP/TDX inherits from node-installer-image#2336
Conversation
The OVMF-SNP and OVMF-TDX overrides at the contrastPkgs level already propagate into contrast.node-installer-image via the fixpoint (the contrast sub-scope is built through packagesFromDirectoryRecursive + newScope and resolves its OVMF-SNP/OVMF-TDX args through the parent final). The explicit inherits were a no-op. Verified by comparing the oci-image-layout drv deps with and without the inherits: both reference the same debug OVMF-SNP drv (which has buildConfig=DEBUG and DEBUG_ON_SERIAL_PORT=TRUE). Signed-off-by: Spyros Seimenis <sse@edgeless.systems>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The OVMF-SNP and OVMF-TDX overrides at the contrastPkgs level already propagate into contrast.node-installer-image via the fixpoint (the contrast sub-scope is built through packagesFromDirectoryRecursive + newScope and resolves its OVMF-SNP/OVMF-TDX args through the parent final). The explicit inherits were a no-op.
Verified by comparing the oci-image-layout drv deps with and without the inherits: both reference the same debug OVMF-SNP drv (which has buildConfig=DEBUG and DEBUG_ON_SERIAL_PORT=TRUE).