Open
Conversation
Member
|
I think keeping the comparison test agaist sev-snp-measure is a good idea. |
Collaborator
Author
Hm... Then maybe, have the generator pkg passed into Would you just like to keep this for manual testing, or would you want it in CI? |
Member
CI I'd say, I wouldn't keep it for manual testing. |
charludo
force-pushed
the
ch/sev-snp-measure-go
branch
from
aa31176 to
4ea2e5d
Compare
charludo
force-pushed
the
ch/sev-snp-measure-go
branch
from
4ea2e5d to
996d69a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Run
nix run .#base.scripts.sev-snp-measure-testerto see identical output between the old python package and the new go package 🥳