Skip to content

deep-research-rwk-orchestrator-agent#1407

Open
rwkopcke wants to merge 2 commits into
ed-donner:mainfrom
rwkopcke:main
Open

deep-research-rwk-orchestrator-agent#1407
rwkopcke wants to merge 2 commits into
ed-donner:mainfrom
rwkopcke:main

Conversation

@rwkopcke

Copy link
Copy Markdown

user provides query
query_agent evaluates the query for clarity and asks the user questions as necessary
once the query is clear, report_manager assigns the query to an orchestrator
who calls a sequence of tools to build the report
these tools include a filter to truncate the number of searches that the writer_agent considers
and a reviewer to evaluate the quality of the report
when the orchestrator has produced a report, report_manager sends the report to the publish_agent

@ed-donner

Copy link
Copy Markdown
Owner

Hey,
I'm super grateful that you've worked on this and are sharing your contribution. It looks like this might not be ready to be merged - please can I ask you to review this:

https://edwarddonner.com/pr

The most common issue is that you've included a file outside community-contributions. This would impact all students on the course. You can see this by going to the "Files changed" tab in this PR; the only changes should be to files in community-contributions.

If there's a good reason to change files outside community-contributions, like an important bug fix, then please let me know (and thank you!)

The 2nd most common reason is that you've not cleared outputs of Notebooks, leading to large code changes. Instructions at the link above.

The 3rd common reason is that you've included too many changes, such as many thousands of lines of code, or a large number of files. I'm grateful for your work, but see the link above for ways we can include this without the repo getting too large.

The PR details in this Github screen shows you the files changed, and at the top right the number of lines added (in Green) and deleted (in Red) by this PR. Typically the Green number should be less than 2,000 and the red number should be 0.

I very much look forward to merging when this is addressed. Thanks so much
Ed

@rwkopcke

Copy link
Copy Markdown
Author

I see the problem. There are two entries in the request and the first is erroneous. I do not know what I must have done to push it into my fork, misspelling included. The second is for agent/2_openai/community_contributions/deep-research-rwk-orchestrator-agent (all contained in the community directory). Can I remove the erroneous first entry? or do I submit another request?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants