Skip to content

GitHub Actions workflow for Python package#1401

Open
KeyuriBuddhe31 wants to merge 4 commits into
ed-donner:mainfrom
KeyuriBuddhe31:main
Open

GitHub Actions workflow for Python package#1401
KeyuriBuddhe31 wants to merge 4 commits into
ed-donner:mainfrom
KeyuriBuddhe31:main

Conversation

@KeyuriBuddhe31

Copy link
Copy Markdown

This workflow installs Python dependencies, runs linting with flake8, and executes tests with pytest across multiple Python versions.

…ns. Added visual reminders and guidance for users to ensure proper environment setup and usage of the notebook.
This workflow installs Python dependencies, runs linting with flake8, and executes tests with pytest across multiple Python versions.
@ed-donner

Copy link
Copy Markdown
Owner

Hey,
I'm super grateful that you've worked on this and are sharing your contribution. It looks like this might not be ready to be merged - please can I ask you to review this:

https://edwarddonner.com/pr

The most common issue is that you've included a file outside community-contributions. This would impact all students on the course. You can see this by going to the "Files changed" tab in this PR; the only changes should be to files in community-contributions.

If there's a good reason to change files outside community-contributions, like an important bug fix, then please let me know (and thank you!)

The 2nd most common reason is that you've not cleared outputs of Notebooks, leading to large code changes. Instructions at the link above.

The 3rd common reason is that you've included too many changes, such as many thousands of lines of code, or a large number of files. I'm grateful for your work, but see the link above for ways we can include this without the repo getting too large.

The PR details in this Github screen shows you the files changed, and at the top right the number of lines added (in Green) and deleted (in Red) by this PR. Typically the Green number should be less than 2,000 and the red number should be 0.

I very much look forward to merging when this is addressed. Thanks so much
Ed

… important collaboration note and updated model names. Added code snippets for API key management and a question generation process for evaluating LLMs. Improved user guidance for executing the notebook.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants