Default empty namespace to "default" in API client - #858
Open
lirenjie95 wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #466
Problem
The API client (
api/pkg/apis/v1alpha1/utils/apiclient.go) appendsnamespaceto the query string as-is. When a caller passes an empty namespace, the request goes out with?namespace=and the server looks objects up under an empty namespace instead of the default one.Fix
withDefaultNamespacehelper that returns"default"for an empty namespace.url.QueryEscape(namespace)call site inapiclient.go(30 occurrences).This matches the convention already used elsewhere in the repo (jobs-manager, stage-manager, target-manager,
model/objectmeta.go, etc.), where an empty namespace falls back to"default".Scope
Only point 1 of the issue is covered by this PR. Point 2 (auditing remaining
symphony-api.gocallers) and point 3 (filling in missing API client methods) are handled separately.Test
Added
apiclient_test.go: an httptest server records the incoming query —GetInstanceswith an empty namespace assertsnamespace=default, and an explicit namespace passes through unchanged.