Fixing log message spam - #386
Open
MaciejKaszynski wants to merge 1 commit into
Open
Conversation
MaciejKaszynski
requested review from
FScholPer,
NicolasFussberger,
anmittag,
antonkri,
pawelrutkaq and
ramceb
as code owners
July 29, 2026 12:28
MaciejKaszynski
requested a deployment
to
workflow-approval
July 29, 2026 12:28 — with 
GitHub Actions
Waiting
GitHub Actions
Waiting
MaciejKaszynski
requested a deployment
to
workflow-approval
July 29, 2026 12:28 — with
GitHub Actions
Waiting
GitHub Actions
Waiting
License Check Results🚀 The license check job ran with the Bazel command: bazel run --lockfile_mode=error //:license-checkStatus: Click to expand output |
|
The created documentation from the pull request is available at: docu-html |
danth
reviewed
Jul 29, 2026
| @@ -464,10 +462,6 @@ bool ProcessGroupManager::sendResponse(ControlClientMessage msg) | |||
| << static_cast<int>(msg.request_or_response_) << ") re state" | |||
| << msg.process_group_state_.pg_state_name_ << "of PG" << msg.process_group_state_.pg_name_; | |||
| ret = scc->sendResponse(msg); | |||
Member
There was a problem hiding this comment.
Would be nice to clean up this variable which is not necessary since the if was removed
Suggested change
| ret = scc->sendResponse(msg); | |
| return scc->sendResponse(msg); |
| init_cv_.notify_all(); | ||
| } | ||
|
|
||
| loadControlNudge(); |
WilliamRoebuck
approved these changes
Jul 29, 2026
WilliamRoebuck
left a comment
WilliamRoebuck
left a comment
Contributor
There was a problem hiding this comment.
Looks good, I ran the complex rep failure test to make sure we don't lose 100ms due to the lack of polling, but look at these results!
Before:
Stats over 10 runs: max = 15.0s, min = 10.1s, avg = 12.9s, dev = 1.7s
After:
Stats over 10 runs: max = 9.2s, min = 7.4s, avg = 8.3s, dev = 0.6s
| static void my_signal_handler(int) | ||
| { | ||
| em_cancelled.store(true); | ||
| ControlClientChannel::nudgeControlClientHandler(); |
Contributor
There was a problem hiding this comment.
nitpick: nudgeControlClientHandler uses SCORE_LANGUAGE_FUTURECPP_ASSERT_MESSAGE and we do not have a signal-safe assertion handler right now.
It also uses LM_LOG_DEBUG to log a message, which probably also not valid to call from a signal handler.
Contributor
There was a problem hiding this comment.
Could this be called before the control client is setup? E.g. launch manager is started but directly receives a SIGTERM/SIGINT
Member
There was a problem hiding this comment.
Once #303 is merged we can use the new signal-safe logging functions from there.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes unlimited polling on the control channel for a response to be available causing the spam of info messages:
Also some small cleanup of
mmaps