Graph refactor initial components - #370
Merged
MaciejKaszynski merged 25 commits intoJul 29, 2026
Merged
Conversation
WilliamRoebuck
requested a deployment
to
workflow-approval
July 24, 2026 14:58 — with
GitHub Actions
Waiting
WilliamRoebuck
requested a deployment
to
workflow-approval
July 24, 2026 14:58 — with
GitHub Actions
Waiting
License Check Results🚀 The license check job ran with the Bazel command: bazel run --lockfile_mode=error //:license-checkStatus: Click to expand output |
WilliamRoebuck
force-pushed
the
feature/process-mon-refactor-1
branch
from
July 24, 2026 15:00
fe8eca0 to
04b715d
Compare
WilliamRoebuck
requested a deployment
to
workflow-approval
July 24, 2026 15:00 — with
GitHub Actions
Waiting
WilliamRoebuck
requested a deployment
to
workflow-approval
July 24, 2026 15:00 — with
GitHub Actions
Waiting
WilliamRoebuck
force-pushed
the
feature/process-mon-refactor-1
branch
from
July 24, 2026 15:02
04b715d to
5001193
Compare
WilliamRoebuck
requested a deployment
to
workflow-approval
July 24, 2026 15:02 — with
GitHub Actions
Waiting
WilliamRoebuck
requested a deployment
to
workflow-approval
July 24, 2026 15:02 — with
GitHub Actions
Waiting
WilliamRoebuck
force-pushed
the
feature/process-mon-refactor-1
branch
from
July 24, 2026 15:11
5001193 to
9c02cd9
Compare
WilliamRoebuck
requested a deployment
to
workflow-approval
July 24, 2026 15:11 — with
GitHub Actions
Waiting
WilliamRoebuck
requested a deployment
to
workflow-approval
July 24, 2026 15:11 — with
GitHub Actions
Waiting
|
The created documentation from the pull request is available at: docu-html |
MaciejKaszynski
requested changes
Jul 27, 2026
MaciejKaszynski
left a comment
Contributor
There was a problem hiding this comment.
Looks good, would really like to split this into separate folders because it's a bit unclear if we are at the component level or process level.
danth
suggested changes
Jul 27, 2026
danth
reviewed
Jul 27, 2026
WilliamRoebuck
force-pushed
the
feature/process-mon-refactor-1
branch
from
July 28, 2026 08:56
ccdddfe to
bcbda43
Compare
This reverts commit 3653511.
WilliamRoebuck
force-pushed
the
feature/process-mon-refactor-1
branch
from
July 29, 2026 08:03
58f2161 to
27651be
Compare
WilliamRoebuck
requested a deployment
to
workflow-approval
July 29, 2026 08:03 — with
GitHub Actions
Waiting
WilliamRoebuck
requested a deployment
to
workflow-approval
July 29, 2026 08:03 — with
GitHub Actions
Waiting
FScholPer
reviewed
Jul 29, 2026
FScholPer
left a comment
Contributor
There was a problem hiding this comment.
Small remark for the tests
WilliamRoebuck
requested a deployment
to
workflow-approval
July 29, 2026 08:37 — with
GitHub Actions
Waiting
WilliamRoebuck
requested a deployment
to
workflow-approval
July 29, 2026 08:37 — with
GitHub Actions
Waiting
danth
approved these changes
Jul 29, 2026
WilliamRoebuck
temporarily deployed
to
workflow-approval
July 29, 2026 09:59 — with
GitHub Actions
Inactive
WilliamRoebuck
temporarily deployed
to
workflow-approval
July 29, 2026 09:59 — with
GitHub Actions
Inactive
MaciejKaszynski
approved these changes
Jul 29, 2026
NicolasFussberger
approved these changes
Jul 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR introduces some initial components required for an upcoming refactor to the
GraphandProcessInfoNodeclasses. Firstly, we want to introduce some components that are more easily understood and unit tested. The next PR will integrate these into existing code. Excluding interfaces and data-only classes, the new components are:ComponentEventQueue- Allows us to handle component state changes sequentially in GraphProcessMonitor- DecouplesProcessInfoNodefromGraphand allows us to simplify its APIsThe refactor aims to address the following concerns:
Graph