Run clang format on code base

[paulquiring]

• All Cpp files are formatted
• Enables clang-format pre-commit hook
• Update in code coverage workflow
• Update in MODULE.bazel

[github-actions]

License Check Results

🚀 The license check job ran with the Bazel command:

bazel run --lockfile_mode=error //:license-check

Status: ⚠️ Needs Review

Click to expand output

[License Check Output]
Extracting Bazel installation...
Starting local Bazel server (8.6.0) and connecting to it...
INFO: Invocation ID: b0bc3a30-8a6d-4591-a589-a5ef8c9a003d
Computing main repo mapping: 
Computing main repo mapping: 
Loading: 
Loading: 0 packages loaded
Loading: 0 packages loaded
Loading: 0 packages loaded
Loading: 0 packages loaded
    currently loading: 
Loading: 0 packages loaded
    currently loading: 
Loading: 0 packages loaded
    currently loading: 
Loading: 0 packages loaded
    currently loading: 
Loading: 0 packages loaded
    currently loading: 
Loading: 0 packages loaded
    currently loading: 
Analyzing: target //:license-check (1 packages loaded, 0 targets configured)
Analyzing: target //:license-check (1 packages loaded, 0 targets configured)

Analyzing: target //:license-check (39 packages loaded, 10 targets configured)

Analyzing: target //:license-check (66 packages loaded, 10 targets configured)

Analyzing: target //:license-check (90 packages loaded, 10 targets configured)

Analyzing: target //:license-check (137 packages loaded, 302 targets configured)

Analyzing: target //:license-check (157 packages loaded, 3630 targets configured)

Analyzing: target //:license-check (162 packages loaded, 6249 targets configured)

Analyzing: target //:license-check (167 packages loaded, 6298 targets configured)

Analyzing: target //:license-check (167 packages loaded, 6298 targets configured)

Analyzing: target //:license-check (170 packages loaded, 8185 targets configured)

Analyzing: target //:license-check (172 packages loaded, 11381 targets configured)

Analyzing: target //:license-check (174 packages loaded, 11409 targets configured)

Analyzing: target //:license-check (174 packages loaded, 11409 targets configured)

Analyzing: target //:license-check (174 packages loaded, 11409 targets configured)

Analyzing: target //:license-check (174 packages loaded, 11409 targets configured)

INFO: Analyzed target //:license-check (175 packages loaded, 11535 targets configured).
[14 / 16] [Prepa] JavaToolchainCompileBootClasspath external/rules_java+/toolchains/platformclasspath.jar
[15 / 16] Building license.check.license_check.jar (); 0s disk-cache, multiplex-worker
INFO: Found 1 target...
Target //:license.check.license_check up-to-date:
  bazel-bin/license.check.license_check
  bazel-bin/license.check.license_check.jar
INFO: Elapsed time: 33.503s, Critical Path: 2.61s
INFO: 16 processes: 12 internal, 3 processwrapper-sandbox, 1 worker.
INFO: Build completed successfully, 16 total actions
INFO: Running command line: bazel-bin/license.check.license_check ./formatted.txt <args omitted>
usage: org.eclipse.dash.licenses.cli.Main [-batch <int>] [-cd <url>]
       [-confidence <int>] [-ef <url>] [-excludeSources <sources>] [-help] [-lic
       <url>] [-project <shortname>] [-repo <url>] [-review] [-summary <file>]
       [-timeout <seconds>] [-token <token>]

[github-actions]

The created documentation from the pull request is available at: docu-html

[MaciejKaszynski]

I dont think we should use the branch. I think in general people use the commit tag so that CI is stable even when template is changed.
So if we need newer stuff I would just get the commit tag of main that we need.

[paulquiring]

I understand, but I’d prefer an automatic update. In the example main is used:
C++ Coverage Workflow
Fail early fail often.

[MaciejKaszynski]

@NicolasFussberger Deciding vote?

Think that failing early is good for our code, a major change in the template would mean we are blocked from PRs on our repo until we fix the CI

[danth]

Pinning to a specific commit is also recommended to avoid supply chain attacks, although debatable whether that matters between our own repos. That page is a good read either way 😄

[NicolasFussberger]

I guess I would also favor the fixed commits, with either a bot that updates this regularly or we have to update this manually regularly.

With directly using main, when they roll out breaking changes it would just break our pipelines and we cannot distinguish between minor changes and major changes.
Would be great if we could pin to version 1.x.x or something like that so that we get the latest as long as its not a breaking change.

[paulquiring]

All right then, I’ll pin that version. I think we should check every now and then to see if there are any newer versions.