fix(lifecycle_client): link lifecycle_mock against lifecyclemanager t… - #337
Merged
NicolasFussberger merged 6 commits intoJul 29, 2026
Conversation
Chahult
requested a deployment
to
workflow-approval
July 21, 2026 11:17 — with
GitHub Actions
Waiting
Chahult
requested a deployment
to
workflow-approval
July 21, 2026 11:17 — with
GitHub Actions
Waiting
License Check Results🚀 The license check job ran with the Bazel command: bazel run --lockfile_mode=error //:license-checkStatus: Click to expand output |
Member
|
@Chahult some checks are failing,are you planning to adapt or delete the PR? |
Chahult
force-pushed
the
fix/lifecycle_mock_vtable_link_v0.2.0
branch
from
July 22, 2026 04:46
bd15106 to
73c9454
Compare
Chahult
requested a deployment
to
workflow-approval
July 22, 2026 04:46 — with
GitHub Actions
Waiting
Chahult
requested a deployment
to
workflow-approval
July 22, 2026 04:46 — with
GitHub Actions
Waiting
Chahult
force-pushed
the
fix/lifecycle_mock_vtable_link_v0.2.0
branch
from
July 22, 2026 11:19
73c9454 to
2da00ec
Compare
Chahult
requested a deployment
to
workflow-approval
July 22, 2026 11:19 — with
GitHub Actions
Waiting
Chahult
requested a deployment
to
workflow-approval
July 22, 2026 11:19 — with
GitHub Actions
Waiting
Chahult
force-pushed
the
fix/lifecycle_mock_vtable_link_v0.2.0
branch
from
July 22, 2026 11:22
2da00ec to
4e403ba
Compare
Chahult
requested a deployment
to
workflow-approval
July 22, 2026 11:22 — with
GitHub Actions
Waiting
Chahult
requested a deployment
to
workflow-approval
July 22, 2026 11:22 — with
GitHub Actions
Waiting
|
The created documentation from the pull request is available at: docu-html |
Chahult
force-pushed
the
fix/lifecycle_mock_vtable_link_v0.2.0
branch
from
July 23, 2026 04:37
4e403ba to
9ae0e52
Compare
Chahult
requested a deployment
to
workflow-approval
July 23, 2026 04:37 — with
GitHub Actions
Waiting
Chahult
requested a deployment
to
workflow-approval
July 23, 2026 04:37 — with
GitHub Actions
Waiting
Contributor
Author
|
@NicolasFussberger Could you please review |
Contributor
Author
Adapt the changes for config management |
Chahult
force-pushed
the
fix/lifecycle_mock_vtable_link_v0.2.0
branch
from
July 23, 2026 05:56
9ae0e52 to
2de1db3
Compare
Chahult
requested a deployment
to
workflow-approval
July 23, 2026 05:56 — with
GitHub Actions
Waiting
Chahult
requested a deployment
to
workflow-approval
July 23, 2026 05:56 — with
GitHub Actions
Waiting
lifecycle_mock provides a mock of LifeCycleManager which inherits from the concrete class. Without :lifecyclemanager in its deps the vtable symbol is undefined when building lifecycle_mock as a shared library (--no-allow-shlib-undefined). Also guard all ApplicationContext callbacks against null to prevent std::bad_function_call when a global ApplicationContext is constructed before any ApplicationContextMock instance exists.
Chahult
force-pushed
the
fix/lifecycle_mock_vtable_link_v0.2.0
branch
from
July 23, 2026 06:21
2de1db3 to
5ddb37e
Compare
Chahult
requested a deployment
to
workflow-approval
July 23, 2026 06:21 — with
GitHub Actions
Waiting
Chahult
requested a deployment
to
workflow-approval
July 24, 2026 04:59 — with
GitHub Actions
Waiting
NicolasFussberger
requested changes
Jul 27, 2026
Chahult
requested a deployment
to
workflow-approval
July 27, 2026 08:35 — with
GitHub Actions
Waiting
Chahult
requested a deployment
to
workflow-approval
July 27, 2026 08:35 — with
GitHub Actions
Waiting
Chahult
force-pushed
the
fix/lifecycle_mock_vtable_link_v0.2.0
branch
from
July 27, 2026 08:44
279936a to
b5ac84b
Compare
Chahult
requested a deployment
to
workflow-approval
July 27, 2026 08:44 — with
GitHub Actions
Waiting
Chahult
requested a deployment
to
workflow-approval
July 27, 2026 08:44 — with
GitHub Actions
Waiting
Chahult
force-pushed
the
fix/lifecycle_mock_vtable_link_v0.2.0
branch
from
July 27, 2026 08:52
b5ac84b to
0df76f4
Compare
Chahult
requested a deployment
to
workflow-approval
July 27, 2026 08:52 — with
GitHub Actions
Waiting
Chahult
requested a deployment
to
workflow-approval
July 27, 2026 08:52 — with
GitHub Actions
Waiting
- Move lifecycle_mocks_UT from examples/ into lifecycle_client/src/ (self-contained test, not coupled to the example app) - Remove lifecycle_test_mocks aggregator target; adapt lifecycle_mock_cc in //score/launch_manager to aggregate all three mock targets instead - Revert accidental visibility widening on applicationcontext, application, and runapplication back to //score/launch_manager:__subpackages__
Chahult
force-pushed
the
fix/lifecycle_mock_vtable_link_v0.2.0
branch
from
July 27, 2026 14:42
0df76f4 to
e179e93
Compare
Chahult
requested a deployment
to
workflow-approval
July 27, 2026 14:42 — with
GitHub Actions
Waiting
Chahult
requested a deployment
to
workflow-approval
July 27, 2026 14:42 — with
GitHub Actions
Waiting
Contributor
Author
|
@NicolasFussberger Could you please review again. |
NicolasFussberger
temporarily deployed
to
workflow-approval
July 29, 2026 05:17 — with
GitHub Actions
Inactive
NicolasFussberger
temporarily deployed
to
workflow-approval
July 29, 2026 05:17 — with
GitHub Actions
Inactive
NicolasFussberger
temporarily deployed
to
workflow-approval
July 29, 2026 05:27 — with
GitHub Actions
Inactive
NicolasFussberger
temporarily deployed
to
workflow-approval
July 29, 2026 05:27 — with
GitHub Actions
Inactive
NicolasFussberger
approved these changes
Jul 29, 2026
Contributor
|
@Chahult I hope you don't mind, I updated the bazel lockfile because the PR check was failing after merging in latest main. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…o resolve vtable
lifecycle_mock provides a mock implementation of LifeCycleManager, which inherits from the concrete class defined in lifecyclemanager.cpp. Without linking against the :lifecyclemanager target, the vtable symbol is undefined when building lifecycle_mock as a shared library (--no-allow-shlib-undefined).
Added :lifecyclemanager to lifecycle_mock's deps to provide the vtable.