Run integration tests on QNX via QEMU - #328
Open
danth wants to merge 8 commits into
Open
Conversation
License Check Results🚀 The license check job ran with the Bazel command: bazel run --lockfile_mode=error //:license-checkStatus: Click to expand output |
|
The created documentation from the pull request is available at: docu-html |
This comment was marked as outdated.
This comment was marked as outdated.
MaciejKaszynski
requested changes
Jul 24, 2026
2 tasks
This comment was marked as outdated.
This comment was marked as outdated.
danth
requested a deployment
to
workflow-approval
August 3, 2026 09:47 — with
GitHub Actions
Waiting
danth
requested a deployment
to
workflow-approval
August 3, 2026 09:47 — with
GitHub Actions
Waiting
danth
requested a deployment
to
workflow-approval
August 3, 2026 09:49 — with
GitHub Actions
Waiting
danth
requested a deployment
to
workflow-approval
August 3, 2026 09:49 — with
GitHub Actions
Waiting
danth
marked this pull request as ready for review
August 3, 2026 10:03
Our Bazel toolchain for Python does not work with QNX, so we need to use built-in libraries to parse the results instead.
With proper use of Bazel platforms rather than configs, I think it would be possible to do this in a much cleaner way. However that would require deeper changes across our codebase and possibly in the test frameworks as well.
danth
requested a deployment
to
workflow-approval
August 3, 2026 15:28 — with
GitHub Actions
Waiting
danth
requested a deployment
to
workflow-approval
August 3, 2026 15:28 — with
GitHub Actions
Waiting
This decouples the choice of Docker/QEMU/native from the choice of Linux/QNX. Then, targets are marked as compatible only if the current combination is known to work. The existing bazelrc shortcuts are updated to set the new flags, so what you actually type at the command line has not changed. The benefit is that running QNX tests with the wrong shortcut will now just list them as skipped, rather than giving a cryptic error.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #316.
Outstanding issues:
--configargument is now needed to run unit tests, as otherwise the unit test framework adds an unwanted second layer of emulation to the integration tests. Since they are using--run_underit is difficult to avoid this.Some of these could be tackled in future PRs.