mw/com/impl: Internally use memory::DataTypeSizeInfo - #813
Merged
Conversation
crimson11
requested review from
LittleHuba,
bemerybmw,
castler,
hoe-jo and
limdor
as code owners
July 30, 2026 13:28
crimson11
force-pushed
the
mf_use_datatype_size_info
branch
from
July 30, 2026 14:10
098d64a to
a84541a
Compare
LittleHuba
requested changes
Jul 30, 2026
LittleHuba
left a comment
LittleHuba
left a comment
Contributor
There was a problem hiding this comment.
I'd like to discuss different approaches to this topic.
This is not a hard no, I just want to brainstorm for ideas.
Contributor
Author
Sure! I'm curious for your proposals! Low level I want to "extend" a type used in the public API ... and I have no clue how to do this minimal invasive - opposed to creating a NEW type and deprecate all APIs with the old type and introduce new/overloads with the new Type! In this case that would even cascade as |
crimson11
force-pushed
the
mf_use_datatype_size_info
branch
3 times, most recently
from
July 31, 2026 12:54
7802866 to
a0334af
Compare
bemerybmw
requested changes
Aug 3, 2026
bemerybmw
reviewed
Aug 3, 2026
crimson11
force-pushed
the
mf_use_datatype_size_info
branch
from
August 3, 2026 12:18
a0334af to
ee884f0
Compare
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
crimson11
force-pushed
the
mf_use_datatype_size_info
branch
from
August 3, 2026 15:00
ee884f0 to
25fead2
Compare
The type DataTypeMetaInfo, which we use on our public interface is too weak! It doesn't assure invariants on size/alignment, which C++ demands: size has to be always a power of two and be an integer multiple of tzhe alignment. This commit switches to internal use of memory::DataTypeSizeInfo which forces this. On the public interface we keep the weak DataTypeMetaInfo for now to avoid a breaking change! In the public layer we transform DataTypeMetaInfo to DataTypeSizeInfo. In case this isn't possible because DataTypeMetaInfo is invalid, we return an error in the public API.
IGenericSkeletonEventBindingFactory has been shifted to plumbing folder.
crimson11
force-pushed
the
mf_use_datatype_size_info
branch
from
August 3, 2026 15:05
25fead2 to
6e9aa5c
Compare
| const SkeletonEventProperties& event_properties, | ||
| const ElementFqId& element_fq_id, | ||
| const DataTypeMetaInfo& size_info, | ||
| const memory::DataTypeSizeInfo& size_info, |
bemerybmw
approved these changes
Aug 4, 2026
crimson11
enabled auto-merge
August 4, 2026 08:59
LittleHuba
approved these changes
Aug 4, 2026
LittleHuba
left a comment
LittleHuba
left a comment
Contributor
There was a problem hiding this comment.
Discussed with @crimson11 offline. Agreed to proceed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The type DataTypeMetaInfo, which we use on our
public interface is too weak! It doesn't assure
invariants on size/alignment, which C++ demands:
size has to be always a power of two and be an
integer multiple of tzhe alignment.
This commit switches to internal use of memory::DataTypeSizeInfo which forces this. On the public interface we keep the weak DataTypeMetaInfo for now to avoid a breaking change! In the public layer we transform DataTypeMetaInfo to DataTypeSizeInfo. In case this isn't possible because DataTypeMetaInfo is invalid, we return an error in the public API.