Skip to content

Keep the HBD interest estimate visible and gate the claim on it #1649

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
feruzm merged 4 commits into from
Aug 23, 2026
Merged

Keep the HBD interest estimate visible and gate the claim on it #1649

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
2f4de1a
Keep the HBD interest estimate visible and gate the claim on it
feruzm Aug 23, 2026
cc36dff
Compute the interest estimate the way the chain settles it
feruzm Aug 23, 2026
c121ea1
Read the savings timestamps as the instants they are
feruzm Aug 23, 2026
b7e3e34
Take the spec's cache keys from the real query options
feruzm Aug 23, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
168 changes: 57 additions & 111 deletions ...namicPages)/profile/[username]/wallet/(token)/_components/profile-wallet-hbd-interest.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,21 +11,17 @@ import { useQuery } from "@tanstack/react-query";
import clsx from "clsx";
import i18next from "i18next";
import { useMemo } from "react";
import { dayjs, formattedNumber, parseAsset, secondDiff } from "@/utils";
import {
formattedNumber,
getHbdSavingsInterestState,
MINIMUM_HBD_SAVINGS_AMOUNT
} from "@/utils";

interface Props {
username: string;
className?: string;
}

// Hive stores HBD balances with three decimal places, so accruing interest
// effectively requires holding at least 0.001 HBD in savings. Below that
// threshold there are no satoshis to accumulate seconds against.
const MINIMUM_SAVINGS_BALANCE = 0.001;
const INTEREST_INTERVAL_DAYS = 30;
const SECONDS_PER_YEAR = 365 * 24 * 60 * 60;
const UNIX_EPOCH = "1970-01-01T00:00:00";

export function ProfileWalletHbdInterest({ username, className }: Props) {
const { activeUser } = useActiveAccount();
const isOwnProfile = activeUser?.username === username;
Expand All @@ -44,91 +40,42 @@ export function ProfileWalletHbdInterest({ username, className }: Props) {

const aprAnnualPercent = useMemo(() => hbdInterestRate / 100, [hbdInterestRate]);

const savingsBalance = useMemo(() => {
const balanceString = account?.savings_hbd_balance ?? "0.000 HBD";
return parseAsset(balanceString).amount;
}, [account?.savings_hbd_balance]);

const trackedHbdSeconds = useMemo(() => {
const value = account?.savings_hbd_seconds;

if (typeof value === "number" && Number.isFinite(value)) {
return value / 1000;
}

if (typeof value === "string") {
const parsed = Number.parseFloat(value);
if (Number.isFinite(parsed)) {
return parsed / 1000;
}
}

return 0;
}, [account?.savings_hbd_seconds]);

const lastUpdate = useMemo(() => {
const value = account?.savings_hbd_seconds_last_update;
if (!value || value === UNIX_EPOCH) {
return null;
}

const parsed = dayjs(value);
return parsed.isValid() ? parsed : null;
}, [account?.savings_hbd_seconds_last_update]);

const lastInterestPayment = useMemo(() => {
const value = account?.savings_hbd_last_interest_payment;
if (!value || value === UNIX_EPOCH) {
return null;
}
const parsed = dayjs(value);
return parsed.isValid() ? parsed : null;
}, [account?.savings_hbd_last_interest_payment]);

const now = dayjs();

const claimReferenceDate = lastInterestPayment ?? lastUpdate;

const secondsSinceLastUpdate = useMemo(() => {
const value = account?.savings_hbd_seconds_last_update;
if (!value || value === UNIX_EPOCH) {
return 0;
}

return secondDiff(value);
}, [account?.savings_hbd_seconds_last_update]);

const pendingSeconds = savingsBalance * secondsSinceLastUpdate;
const secondsToEstimate = trackedHbdSeconds + pendingSeconds;

const pendingInterest = useMemo(() => {
if (hbdInterestRate <= 0) {
return 0;
}

const aprDecimal = hbdInterestRate / 10000;
return (secondsToEstimate / SECONDS_PER_YEAR) * aprDecimal;
}, [hbdInterestRate, secondsToEstimate]);
const {
savingsBalance,
pendingInterest,
hasSavingsBalance,
hasPendingInterest,
isEmpty,
nextClaimDate,
needsDepositToClaim,
canClaim
} = useMemo(
() =>
getHbdSavingsInterestState({
savingsHbdBalance: account?.savings_hbd_balance,
savingsHbdSeconds: account?.savings_hbd_seconds,
savingsHbdSecondsLastUpdate: account?.savings_hbd_seconds_last_update,
savingsHbdLastInterestPayment: account?.savings_hbd_last_interest_payment,
hbdInterestRate
}),
[
account?.savings_hbd_balance,
account?.savings_hbd_seconds,
account?.savings_hbd_seconds_last_update,
account?.savings_hbd_last_interest_payment,
hbdInterestRate
]
);

const pendingInterestDisplay = formattedNumber(pendingInterest);
const hasPendingInterest = pendingInterest >= MINIMUM_SAVINGS_BALANCE;

const nextClaimDate = claimReferenceDate
? claimReferenceDate.add(INTEREST_INTERVAL_DAYS, "day")
: null;

const hasMinimumBalance = savingsBalance >= MINIMUM_SAVINGS_BALANCE;
const canClaim = Boolean(
hasMinimumBalance &&
nextClaimDate &&
now.isAfter(nextClaimDate) &&
hasPendingInterest
);

const nextClaimDescription = (() => {
if (!hasMinimumBalance) {
return i18next.t("profile-wallet.hbd-interest.minimum-balance", {
amount: MINIMUM_SAVINGS_BALANCE.toFixed(3),
// Interest keeps accruing on the banked balance-seconds even after the
// savings balance is emptied, but releasing it means transferring 0.001 HBD
// back out of savings, so it stays stuck until something is deposited.
if (needsDepositToClaim) {
return i18next.t("profile-wallet.hbd-interest.deposit-to-claim", {
amount: MINIMUM_HBD_SAVINGS_AMOUNT.toFixed(3),
});
}

Expand All @@ -147,27 +94,21 @@ export function ProfileWalletHbdInterest({ username, className }: Props) {

const nextClaimExact = nextClaimDate?.format("LLL");

const helperText = hasMinimumBalance
const helperText = hasSavingsBalance
? i18next.t("profile-wallet.hbd-interest.note", {
apr: aprAnnualPercent.toFixed(3),
})
: undefined;
: i18next.t("profile-wallet.hbd-interest.minimum-balance", {
amount: MINIMUM_HBD_SAVINGS_AMOUNT.toFixed(3),
});

if (savingsBalance < MINIMUM_SAVINGS_BALANCE) {
// Nothing saved and nothing accrued: there is no estimate worth a card. A
// zero savings balance on its own is not enough to hide it, because the
// interest already earned on it is still owed and still claimable.
if (isEmpty) {
return null;
}

const claimButton = (
<Button
appearance="primary"
className="w-full sm:w-auto"
size="sm"
disabled={!isOwnProfile || !canClaim}
>
{i18next.t("profile-wallet.hbd-interest.claim-button")}
</Button>
);

return (
<div
className={clsx(
Expand All @@ -184,16 +125,23 @@ export function ProfileWalletHbdInterest({ username, className }: Props) {
{pendingInterestDisplay} HBD
</div>
</div>
{isOwnProfile && canClaim ? (
{/* Only offered once there is interest to collect: below 0.001 HBD the
chain has nothing to pay out, so the button would always fail. */}
{isOwnProfile && hasPendingInterest && (
<WalletOperationsDialog
Comment thread
qodo-code-review[bot] marked this conversation as resolved.
asset="HBD"
operation={AssetOperation.ClaimInterest}
to={username}
>
{claimButton}
<Button
appearance="primary"
className="w-full sm:w-auto"
size="sm"
disabled={!canClaim}
>
{i18next.t("profile-wallet.hbd-interest.claim-button")}
</Button>
</WalletOperationsDialog>
) : (
claimButton
)}
</div>

Expand All @@ -220,9 +168,7 @@ export function ProfileWalletHbdInterest({ username, className }: Props) {
<div className="text-sm text-gray-700 dark:text-gray-300">
{savingsBalance.toFixed(3)} HBD
</div>
{helperText && (
<div className="text-xs text-gray-500 dark:text-gray-400">{helperText}</div>
)}
<div className="text-xs text-gray-500 dark:text-gray-400">{helperText}</div>
</div>
</div>
</div>
Expand Down
1 change: 1 addition & 0 deletions apps/web/src/features/i18n/locales/en-US.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3853,6 +3853,7 @@
"next-ready": "Ready to claim now",
"next-in": "Available {{relative}}",
"next-unknown": "Interest schedule unavailable",
"deposit-to-claim": "Deposit at least {{amount}} HBD to savings to release this interest.",
"next-date": "On {{date}}",
"balance-label": "Savings balance",
"minimum-balance": "Interest accrues once you hold at least {{amount}} HBD in savings.",
Expand Down
Loading
Loading