Self-hosted: say the Hivesigner client id is filled in for hosted blogs - #1357
Conversation
The registration job writes the shared ecency.app client id for every active tenant, but the Configuration Editor still told the owner to register an app themselves or email us and then type the id in. That describes work a managed tenant will never do, and reads as a broken login until they do it. Rewrites the client id and login methods descriptions to state the hosted case first, keep the self-hosted route, and say an owner's own id is never overwritten, which the reconcile already guarantees but nothing told them. Locks it with a test asserting the hosted case is described as automatic, so the editor and the job cannot drift apart again the way they just did.
|
Warning Review limit reached
Next review available in: 6 minutes You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (2)
📝 WalkthroughWalkthroughThe floating-menu configuration now explains automatic Hivesigner client ID provisioning for Ecency-hosted blogs, custom client ID registration, and preservation of owner-provided IDs. A test verifies the hosted Hivesigner client ID description. ChangesHivesigner configuration guidance
Estimated code review effort: 1 (Trivial) | ~5 minutes Possibly related PRs
Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: cc296f9e99
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| type: 'string', | ||
| description: | ||
| "Hivesigner login stays hidden until this is set. Either register your own Hivesigner app and put its id here, or email hello@ecency.com to get this site's /auth address registered on the shared ecency.app app, then put ecency.app here.", | ||
| "Hivesigner login stays hidden until this is set. On a blog hosted by Ecency the shared ecency.app app is filled in for you, once this site's /auth address has been registered on chain, so there is normally nothing to do here. To use a different app, register your own and put its id here; it is never overwritten. On a self-hosted instance, register your own app or email hello@ecency.com.", |
There was a problem hiding this comment.
For a self-hosted instance that uses the email/shared-app path, this sentence stops before telling the owner to save ecency.app in this field. There is no managed registration job for that case; the deployment guide still describes the email route as getting /auth registered and then putting ecency.app here, and while the field stays blank the Hivesigner button remains hidden. Please keep the hosted automatic copy, but retain the explicit then put ecency.app here instruction for self-hosters.
Useful? React with 👍 / 👎.
There was a problem hiding this comment.
Valid, and fixed in a6435e3. The reconcile only iterates the hosting database, so nothing writes this field on a self-hosted instance: an owner who took the email route and waited would have watched the button stay hidden for a step that was never going to happen on its own.
The self-hosted branch now reads: "On a self-hosted instance nothing fills this in for you: either register your own app and put its id here, or email hello@ecency.com to get this site's /auth address registered on the shared app and then put ecency.app here."
Also added a test for it. The existing gives both routes to a working setup case asserted the three substrings were present, and all three still were in the revision that had dropped the save step, which is how this got past review in the first place.
The rewrite dropped it. Nothing writes this field on a self-hosted instance: the reconcile iterates the hosting database, so an owner who emails us and waits sees the login stay hidden for a step that was never going to happen by itself. Restores the instruction on the self-hosted branch of the description, and adds a test for it. The existing case asserted the three substrings were present, and they all were in the revision that had dropped the step, so it caught nothing.
1 participant
Follow-up to #1354, which is now live: the registration job has run against production and all eight active tenants carry
ecency.app, served and on chain.That makes the Configuration Editor's own text wrong. It still says:
A managed tenant never does any of that. The job sets the id for them, so the instruction describes work that will not happen and makes a working login look broken until the owner acts on it.
Changes
decideClientIdreturningleavefor any non-shared value, but nothing said so, and without it setting your own app reads as a change something else may undo.gives both routes to a working setupcase is untouched.hivesigner-setup.ts's notice is deliberately left alone: it fires only when no client id is set, which on managed hosting no longer happens, and it stays correct for self-hosters, where nothing registers on their behalf.Verification
vitest run src/features/floating-menu/83 passed.config.jsonresolution error.Summary by CodeRabbit