This repository was archived by the owner on Aug 31, 2022. It is now read-only.
Remove the OgRouteContext provider. This is now built in to OG.#12
Merged
Conversation
claudiu-cristea
suggested changes
Oct 12, 2016
claudiu-cristea
left a comment
claudiu-cristea
left a comment
Contributor
There was a problem hiding this comment.
This seems a straight solution. I think the service should also be removed in og_menu.services.yml:
og_menu.og_route_context:
class: Drupal\og_menu\ContextProvider\OgRouteContext
arguments: ['@current_route_match']
tags:
- { name: 'context_provider' }BTW, before reviewing this I did a check also on Gizra/og#180. Very nice work, congratulations!
claudiu-cristea
suggested changes
Oct 12, 2016
claudiu-cristea
left a comment
claudiu-cristea
left a comment
Contributor
There was a problem hiding this comment.
See the above comment.
Contributor
|
I requested changes but the issue doesn't turn red. Seems that I don't have some permissions on this project? |
Contributor
Author
|
Thanks for the review! Very good point, I also removed the declaration of the route context in the yaml file. I don't know how the new review system works on Github, it opens some kind of floating dialog which I dislike. |
Contributor
Author
|
In the meantime I got the hang of the new review system, and @claudiu-cristea has the right permissions! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A proposal is made to include a generic context provider in OG: Gizra/og#180
The context provider in OG Menu is now obsolete and might even conflict with the one from OG.