Skip to content
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion DESCRIPTION
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
Type: Package
Package: performance
Title: Assessment of Regression Models Performance
Version: 0.16.0.2
Version: 0.16.0.3
Authors@R:
c(person(given = "Daniel",
family = "Lüdecke",
Expand Down
9 changes: 6 additions & 3 deletions NEWS.md
Original file line number Diff line number Diff line change
@@ -1,14 +1,17 @@
# performance 0.16.0.2
# performance (devel)
Comment thread
strengejacke marked this conversation as resolved.

## Changes

* `test_likelihoodratio()` now has a new 'Criterion' column containing the
* `test_likelihoodratio()` now has a new 'Criterion' column containing the
-2 * log-likelihood (-2LL) value for each model.

* Added more details to the troubleshooting-section to the documentation of
Comment thread
strengejacke marked this conversation as resolved.
Outdated
`check_model()`.

## Bug fixes

* Fixed issue in `test_likelihoodratio_ListLavaan()` that was extracting the
absolute model fit (Chisq) from the lavTestLRT output instead of the actual
absolute model fit (Chisq) from the lavTestLRT output instead of the actual
LRT test statistic (Chisq diff).

# performance 0.16.0.1
Expand Down
25 changes: 25 additions & 0 deletions R/check_model.R
Original file line number Diff line number Diff line change
Expand Up @@ -181,6 +181,31 @@
#' If `check_model()` doesn't work as expected, try setting `verbose = TRUE` to
#' get hints about possible problems.
#'
#' If your plots are not rendering correctly in your IDE or you receive an error
#' stating that the viewport is too small, try the following steps to resolve
#' the issue:
#'
#' - *Enlarge the plotting window:* The most common cause is that the plotting
#' pane is simply too small. If you are using RStudio, click and drag the
#' edges of the 'Plots' pane to increase its dimensions, then try plotting
#' again.
#' - *Reset your IDE zoom settings:* If resizing the window doesn't help, your
#' IDE's zoom level might be causing scaling issues. In RStudio, navigate to
#' the menu bar and select *View > Actual Size* to reset the zoom. If you are
#' using a different IDE, look for a similar zoom reset option.
#' - *Adjust Windows display scaling:* On Windows, system-wide display scaling can
#' sometimes interfere with graphical outputs in R. You can adjust this in
#' your system settings: Go to *Start > Settings > System > Display* and locate
#' the `"Scale and layout"` section. Try reducing the scaling percentage (e.g.,
#' to 100%) and restart your IDE.
#' - *Decrease the base font size:* As a code-level workaround, you can reduce the
#' base font size of your plots to help them fit into smaller viewports. If
#' you are using `{ggplot2}`, load the library and adjust your theme before
#' plotting. For example: `theme_set(theme_classic(base_size = 6))`.
Comment on lines +203 to +204
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

To adhere to the repository style guide (line 67) and maintain consistency with the rest of the documentation, please use the :: operator for package functions and the **package** format for package names.

#'   you are using **ggplot2**, load the library and adjust your theme before
#'   plotting. For example: `ggplot2::theme_set(ggplot2::theme_classic(base_size = 6))`. 
References
  1. Always use the :: operator to call functions from other packages. (link)

#' - *Update relevant packages:* Finally, ensure your graphics and layout packages
#' are up to date. You can update your packages (paying special attention to
#' `{ggplot2}` and `{patchwork}`) by running `update.packages(ask = FALSE)`.
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

Use the :: operator for update.packages (from the utils package) and the **package** format for package names, as per the style guide (line 67) and project conventions.

#'   **ggplot2** and **patchwork**) by running `utils::update.packages(ask = FALSE)`. 
References
  1. Always use the :: operator to call functions from other packages. (link)

#'
#' @family functions to check model assumptions and and assess model quality
#'
#' @examplesIf require("lme4") && FALSE
Expand All @@ -202,7 +227,7 @@

#' @rdname check_model
#' @export
check_model.default <- function(

Check warning on line 230 in R/check_model.R

View workflow job for this annotation

GitHub Actions / lint-changed-files / lint-changed-files

file=R/check_model.R,line=230,col=1,[cyclocomp_linter] Reduce the cyclomatic complexity of this expression from 43 to at most 40. Consider replacing high-complexity sections like loops and branches with helper functions.
model = NULL,
panel = TRUE,
check = "all",
Expand Down
26 changes: 26 additions & 0 deletions man/check_model.Rd

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading