Repository navigation
fix(net): keep guest data queued before connect on a guest half-close - #160
Open
TadahiroYamamura wants to merge 1 commit into
Open
TadahiroYamamura wants to merge 1 commit into
TadahiroYamamura wants to merge 1 commit into
Conversation
On mapped TCP, data and a FIN arriving before the upstream connect() finished made us discard the already-acked data before end(). On a graceful close, write the data to the connecting socket before end(); Node sends written data before the FIN. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A5 of #155.
Problem
On mapped TCP, when data and a FIN arrive before the upstream
connect()finishes, the already-ACKed data is discarded beforeend(). When the guest sent 5 bytes and closed immediately, the upstream server received 0 bytes (waiting 0.5s before closing, all 5 bytes arrived).Fix
On a graceful close (
destroy: false), write the queued data to the connecting socket beforeend(). Node's socket sends written data before the FIN. Withdestroy: truethe data is still discarded as before.Tests
Connect over mapped TCP to a server listening on 127.0.0.1, feed data and a FIN before the connection completes, and check that the server receives all bytes before the FIN.
Please check
maxTcpPendingWriteBytes) when it was queued, so the cap is not exceeded. ThewritableLengthcheck done for connected sockets is not applied, since no new guest data arrives after the FINSuggested CHANGELOG entry
Fix data the guest sent over a mapped TCP connection being dropped when the guest half-closed before the upstream connect finished.
🤖 AI (Claude Code) was used for the investigation and for writing the code.
Contribution Agreement
Please ensure this PR follows the guidelines in
CONTRIBUTING.md.By submitting this pull request, I confirm the following:
I understand that the entity Earendil Inc. (incorporated in the state of Delaware in 2025) needs some rights from me in order to utilize my contributions in this PR. As a contributor I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Earendil Inc. can use, modify, copy, and redistribute my contributions, under Earendil Inc.'s choice of terms.