Skip to content

Syntax updates #6239

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
duncdrum wants to merge 9 commits into
base: develop
Choose a base branch
from

Apply suggestions from code review

004897f
Select commit
Loading
Failed to load commit list.
Draft

Syntax updates #6239

Apply suggestions from code review
004897f
Select commit
Loading
Failed to load commit list.
Codacy Production / Codacy Static Code Analysis required action Apr 17, 2026 in 0s

230 new issues (0 max.) of at least severity.

Codacy Here is an overview of what got changed by this pull request:

Issues
======
+ Solved 44
- Added 230
           

Complexity increasing per file
==============================
- extensions/indexes/lucene/src/test/java/org/exist/indexing/lucene/LuceneIndexTest.java  2
         

Complexity decreasing per file
==============================
+ extensions/indexes/lucene/src/test/java/org/exist/indexing/lucene/AnalyzerConfigTest.java  -31
+ extensions/indexes/range/src/test/java/org/exist/xquery/modules/range/Issue4074IndexKeysServletContextTest.java  -7
+ extensions/indexes/vector-it/src/test/java/xquery/lucene/VectorSearchEmbeddingIT.java  -4
         

Clones added
============
- extensions/indexes/ngram/src/test/java/org/exist/indexing/ngram/CustomIndexTest.java  3
- exist-core/src/test/java/org/exist/xquery/ConstructedNodesTest.java  5
- exist-core/src/main/java/org/exist/xquery/functions/fn/FunName.java  1
- exist-core/src/main/java/org/exist/xquery/functions/fn/FunMin.java  1
- exist-core/src/test/java/org/exist/xquery/WindowClauseTest.java  8
- exist-core/src/main/java/org/exist/util/crypto/digest/MessageDigest.java  3
- exist-core/src/main/java/org/exist/xquery/functions/validation/Jing.java  1
- exist-core/src/main/java/org/exist/xquery/update/Delete.java  1
- exist-core/src/test/java/org/exist/IndexerTest.java  4
- exist-core/src/main/java/org/exist/xquery/value/OrderedValueSequence.java  1
- extensions/modules/simpleql/src/main/java/org/exist/xquery/modules/simpleql/SimpleQLModule.java  3
- extensions/indexes/range/src/main/java/org/exist/indexing/range/RangeIndexConfig.java  1
- exist-core/src/test/java/org/exist/xquery/XmldbBinariesTest.java  1
- exist-core/src/test/java/org/exist/xquery/LexerTest.java  1
- extensions/indexes/lucene/src/main/java/org/exist/xquery/modules/lucene/Search.java  1
- exist-core/src/test/java/org/exist/storage/RangeIndexUpdateTest.java  1
- exist-core/src/test/java/org/exist/xquery/functions/util/EvalTest.java  2
- extensions/indexes/ngram/src/main/java/org/exist/xquery/modules/ngram/NGramSearch.java  2
- extensions/modules/file/src/test/java/org/exist/xquery/modules/file/XmldbBinariesTest.java  1
- exist-core/src/main/java/org/exist/xquery/update/Update.java  1
- extensions/modules/simpleql/src/main/java/org/exist/xquery/modules/simpleql/ParseSimpleQL.java  1
- extensions/indexes/lucene/src/main/java/org/exist/xquery/modules/lucene/Field.java  1
- exist-core/src/main/java/org/exist/xquery/functions/validation/Jaxp.java  1
- exist-core/src/test/java/org/exist/xquery/functions/util/ExpandTest.java  2
- extensions/indexes/range/src/main/java/org/exist/xquery/modules/range/Lookup.java  1
- extensions/indexes/lucene/src/main/java/org/exist/indexing/lucene/PlainTextHighlighter.java  1
- extensions/indexes/lucene/src/test/java/org/exist/indexing/lucene/AnalyzerConfigTest.java  2
- extensions/indexes/lucene/src/main/java/org/exist/xquery/modules/lucene/QueryField.java  1
- extensions/indexes/lucene/src/main/java/org/exist/indexing/lucene/LuceneConfig.java  1
- exist-core/src/main/java/org/exist/xquery/functions/util/Expand.java  1
- extensions/indexes/ngram/src/test/java/org/exist/indexing/ngram/MatchListenerTest.java  6
- exist-core/src/test/java/org/exist/xquery/ValueIndexTest.java  1
- exist-core/src/test/java/org/exist/xquery/ConstructedNodesRecoveryTest.java  1
- exist-core/src/main/java/org/exist/xquery/functions/fn/FunMax.java  1
- exist-core/src/test/java/org/exist/xmldb/concurrent/action/RemoveAppendAction.java  1
- exist-core/src/test/java/org/exist/xmldb/concurrent/XMLGenerator.java  2
- exist-core/src/test/java/org/exist/util/sorters/FastQSortTester.java  2
- exist-core/src/test/java/org/exist/xquery/SpecialNamesTest.java  1
- exist-core/src/test/java/org/exist/xquery/functions/fn/DocTest.java  1
- exist-core/src/test/java/org/exist/storage/ReindexRecoveryTest.java  1
- exist-core/src/main/java/org/exist/xquery/functions/fn/FunNamespaceURI.java  2
- exist-core/src/test/java/org/exist/util/hashtable/SequencedLongHashMapTest.java  2
- extensions/indexes/range/src/main/java/org/exist/xquery/modules/range/FieldLookup.java  1
- extensions/contentextraction/src/test/java/org/exist/contentextraction/xquery/ContentFunctionsTest.java  4
- exist-core/src/test/java/org/exist/xquery/functions/fn/CollectionTest.java  1
- exist-core/src/main/java/org/exist/xquery/functions/fn/FunLocalName.java  1
- exist-core/src/test/java/org/exist/Indexer3Test.java  2
         

Clones removed
==============
+ exist-ant/src/main/java/org/exist/ant/RemoveGroupTask.java  -1
+ exist-core/src/main/java/org/exist/xquery/value/DayTimeDurationValue.java  -1
+ exist-core/src/main/java/org/exist/xquery/functions/util/IndexKeyDocuments.java  -1
+ exist-core/src/test/java/org/exist/xquery/functions/validate/AdditionalJingXsdRngTest.java  -2
+ extensions/indexes/lucene/src/test/java/org/exist/indexing/lucene/LuceneMatchListenerTest.java  -2
+ exist-core/src/main/java/org/exist/xmldb/RemoteResourceSet.java  -1
+ exist-core/src/main/java/org/exist/backup/FileSystemBackupDescriptor.java  -1
+ exist-core/src/test/java/org/exist/storage/UpdateTest.java  -2
+ exist-core/src/main/java/org/exist/xquery/functions/util/IndexKeyOccurrences.java  -1
+ exist-core/src/main/java/org/exist/xquery/functions/system/GetRunningXQueries.java  -1
+ exist-core/src/test/java/org/exist/security/FnDocSecurityTest.java  -1
+ exist-core/src/main/java/org/exist/backup/ZipArchiveBackupDescriptor.java  -1
+ exist-core/src/main/java/org/exist/xmldb/LocalResourceSet.java  -1
+ exist-ant/src/main/java/org/exist/ant/RemoveUserTask.java  -1
+ exist-core/src/main/java/org/exist/xquery/value/SubSequence.java  -1
+ exist-core/src/test/java/org/exist/xquery/functions/securitymanager/PermissionsFunctionChmodTest.java  -1
+ exist-core/src/test/java/org/exist/storage/ReplaceTest.java  -1
+ exist-core/src/main/java/org/exist/xquery/functions/fn/FnRandomNumberGenerator.java  -2
+ exist-core/src/main/java/org/exist/util/FastQSort.java  -4
+ extensions/modules/scheduler/src/main/java/org/exist/xquery/modules/scheduler/SchedulerModule.java  -1
+ extensions/indexes/lucene/src/test/java/org/exist/indexing/lucene/SerializeAttrMatchesTest.java  -1
+ extensions/expath/src/main/java/org/expath/exist/ZipFileFunctions.java  -1
+ exist-core/src/test/java/org/exist/storage/ResourceTest.java  -2
+ exist-core/src/main/java/org/exist/client/DocumentView.java  -2
+ exist-core/src/main/java/org/exist/xquery/value/YearMonthDurationValue.java  -1
+ exist-core/src/test/java/org/exist/xmldb/DOMJUnitTest.java  -2

See the complete overview on Codacy

Annotations

Check warning on line 84 in exist-core/src/main/java/org/exist/Indexer.java

See this annotation in the file changed.

@codacy-production codacy-production / Codacy Static Code Analysis

exist-core/src/main/java/org/exist/Indexer.java#L84 

Avoid unused private fields such as 'inCDATASection'.

Check warning on line 93 in exist-core/src/main/java/org/exist/Indexer.java

See this annotation in the file changed.

@codacy-production codacy-production / Codacy Static Code Analysis

exist-core/src/main/java/org/exist/Indexer.java#L93 

Avoid unused private fields such as 'level'.

Check warning on line 1825 in exist-core/src/main/java/org/exist/client/InteractiveClient.java

See this annotation in the file changed.

@codacy-production codacy-production / Codacy Static Code Analysis

exist-core/src/main/java/org/exist/client/InteractiveClient.java#L1825 

Avoid unused local variables such as 'needPassword'.

Check warning on line 60 in exist-core/src/main/java/org/exist/collections/triggers/STXTransformerTrigger.java

See this annotation in the file changed.

@codacy-production codacy-production / Codacy Static Code Analysis

exist-core/src/main/java/org/exist/collections/triggers/STXTransformerTrigger.java#L60 

Avoid unused private fields such as 'handler'.

Check notice on line 87 in exist-core/src/main/java/org/exist/dom/persistent/Match.java

See this annotation in the file changed.

@codacy-production codacy-production / Codacy Static Code Analysis

exist-core/src/main/java/org/exist/dom/persistent/Match.java#L87 

Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes.

Check notice on line 89 in exist-core/src/main/java/org/exist/dom/persistent/Match.java

See this annotation in the file changed.

@codacy-production codacy-production / Codacy Static Code Analysis

exist-core/src/main/java/org/exist/dom/persistent/Match.java#L89 

Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes.

Check warning on line 285 in exist-core/src/main/java/org/exist/dom/persistent/XMLUtil.java

See this annotation in the file changed.

@codacy-production codacy-production / Codacy Static Code Analysis

exist-core/src/main/java/org/exist/dom/persistent/XMLUtil.java#L285 

Avoid using a branching statement as the last in a loop.

Check notice on line 44 in exist-core/src/main/java/org/exist/indexing/AbstractIndex.java

See this annotation in the file changed.

@codacy-production codacy-production / Codacy Static Code Analysis

exist-core/src/main/java/org/exist/indexing/AbstractIndex.java#L44 

Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes.

Check notice on line 45 in exist-core/src/main/java/org/exist/indexing/AbstractIndex.java

See this annotation in the file changed.

@codacy-production codacy-production / Codacy Static Code Analysis

exist-core/src/main/java/org/exist/indexing/AbstractIndex.java#L45 

Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes.

Check notice on line 119 in exist-core/src/main/java/org/exist/launcher/Launcher.java

See this annotation in the file changed.

@codacy-production codacy-production / Codacy Static Code Analysis

exist-core/src/main/java/org/exist/launcher/Launcher.java#L119 

Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes.

Check notice on line 120 in exist-core/src/main/java/org/exist/launcher/Launcher.java

See this annotation in the file changed.

@codacy-production codacy-production / Codacy Static Code Analysis

exist-core/src/main/java/org/exist/launcher/Launcher.java#L120 

Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes.

Check notice on line 124 in exist-core/src/main/java/org/exist/launcher/Launcher.java

See this annotation in the file changed.

@codacy-production codacy-production / Codacy Static Code Analysis

exist-core/src/main/java/org/exist/launcher/Launcher.java#L124 

Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes.

Check notice on line 125 in exist-core/src/main/java/org/exist/launcher/Launcher.java

See this annotation in the file changed.

@codacy-production codacy-production / Codacy Static Code Analysis

exist-core/src/main/java/org/exist/launcher/Launcher.java#L125 

Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes.

Check warning on line 47 in exist-core/src/main/java/org/exist/launcher/SplashScreen.java

See this annotation in the file changed.

@codacy-production codacy-production / Codacy Static Code Analysis

exist-core/src/main/java/org/exist/launcher/SplashScreen.java#L47 

Perhaps 'versionLabel' could be replaced by a local variable.

Check notice on line 114 in exist-core/src/main/java/org/exist/management/impl/LockTable.java

See this annotation in the file changed.

@codacy-production codacy-production / Codacy Static Code Analysis

exist-core/src/main/java/org/exist/management/impl/LockTable.java#L114 

Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes.

Check notice on line 82 in exist-core/src/main/java/org/exist/repo/ExistPkgInfo.java

See this annotation in the file changed.

@codacy-production codacy-production / Codacy Static Code Analysis

exist-core/src/main/java/org/exist/repo/ExistPkgInfo.java#L82 

Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes.

Check notice on line 83 in exist-core/src/main/java/org/exist/repo/ExistPkgInfo.java

See this annotation in the file changed.

@codacy-production codacy-production / Codacy Static Code Analysis

exist-core/src/main/java/org/exist/repo/ExistPkgInfo.java#L83 

Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes.

Check warning on line 99 in exist-core/src/main/java/org/exist/resolver/ResolverFactory.java

See this annotation in the file changed.

@codacy-production codacy-production / Codacy Static Code Analysis

exist-core/src/main/java/org/exist/resolver/ResolverFactory.java#L99 

Avoid reassigning parameters such as 'strCatalogUri'

Check notice on line 118 in exist-core/src/main/java/org/exist/security/PermissionRequiredAspect.java

See this annotation in the file changed.

@codacy-production codacy-production / Codacy Static Code Analysis

exist-core/src/main/java/org/exist/security/PermissionRequiredAspect.java#L118 

These nested if statements could be combined

Check notice on line 66 in exist-core/src/main/java/org/exist/security/internal/RealmImpl.java

See this annotation in the file changed.

@codacy-production codacy-production / Codacy Static Code Analysis

exist-core/src/main/java/org/exist/security/internal/RealmImpl.java#L66 

Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes.

Check notice on line 68 in exist-core/src/main/java/org/exist/security/internal/RealmImpl.java

See this annotation in the file changed.

@codacy-production codacy-production / Codacy Static Code Analysis

exist-core/src/main/java/org/exist/security/internal/RealmImpl.java#L68 

Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes.

Check notice on line 69 in exist-core/src/main/java/org/exist/security/internal/RealmImpl.java

See this annotation in the file changed.

@codacy-production codacy-production / Codacy Static Code Analysis

exist-core/src/main/java/org/exist/security/internal/RealmImpl.java#L69 

Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes.

Check notice on line 73 in exist-core/src/main/java/org/exist/security/internal/RealmImpl.java

See this annotation in the file changed.

@codacy-production codacy-production / Codacy Static Code Analysis

exist-core/src/main/java/org/exist/security/internal/RealmImpl.java#L73 

Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes.

Check warning on line 128 in exist-core/src/main/java/org/exist/security/internal/SecurityManagerImpl.java

See this annotation in the file changed.

@codacy-production codacy-production / Codacy Static Code Analysis

exist-core/src/main/java/org/exist/security/internal/SecurityManagerImpl.java#L128 

Perhaps 'collection' could be replaced by a local variable.

Check warning on line 185 in exist-core/src/main/java/org/exist/storage/BrokerPools.java

See this annotation in the file changed.

@codacy-production codacy-production / Codacy Static Code Analysis

exist-core/src/main/java/org/exist/storage/BrokerPools.java#L185 

An instanceof check is being performed on the caught exception.  Create a separate catch clause for this exception type.
View more details on Codacy Production