Skip to content

fix: PomParser의 XML 외부 엔티티(XXE) 취약점 수정 #147

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
eGovFrameSupport merged 1 commit into from
Sep 7, 2026
+13 −1
Merged

fix: PomParser의 XML 외부 엔티티(XXE) 취약점 수정 #147

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 13 additions & 1 deletion egovframework.rte.rdt/src/main/java/egovframework/rte/rdt/pom/parser/PomParser.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,13 +18,16 @@
import java.io.File;
import java.io.IOException;
import java.io.OutputStream;
import java.io.StringReader;

import org.jdom.Document;
import org.jdom.Element;
import org.jdom.JDOMException;
import org.jdom.Namespace;
import org.jdom.input.SAXBuilder;
import org.jdom.output.XMLOutputter;
import org.xml.sax.EntityResolver;
import org.xml.sax.InputSource;

import egovframework.rte.rdt.pom.exception.PomException;
import egovframework.rte.rdt.pom.unit.DetailPom;
Expand All @@ -45,6 +48,15 @@ public static Pom parse(File file) throws PomException {
DetailPom pom = null;

SAXBuilder builder = new SAXBuilder();
// XXE(XML External Entity Injection, CWE-611) 취약점 방지
// 외부 엔티티·외부 DTD를 읽지 않도록 하며, 내부 엔티티 치환은 기존과 동일하게 동작한다.
builder.setEntityResolver(new EntityResolver() {
public InputSource resolveEntity(String publicId, String systemId) {
return new InputSource(new StringReader(""));
}
});
builder.setFeature("http://xml.org/sax/features/external-parameter-entities", false);
builder.setFeature("http://apache.org/xml/features/nonvalidating/load-external-dtd", false);

try {
Document doc = builder.build(file);
Expand Down Expand Up @@ -151,4 +163,4 @@ public static DetailPom generatePomObjectFromXml(Document doc) {
return pom;
}

}
}
Loading