Repository navigation
Fix histogram overflow bucket accounting - #333
Closed
xiaoxichen wants to merge 1 commit into
Closed
xiaoxichen wants to merge 1 commit into
xiaoxichen wants to merge 1 commit into
Conversation
Histogram observations above the largest configured boundary use the implicit overflow bucket at index boundaries.size(). RCU and thread-buffer aggregation previously omitted that slot during merge, leaving the sum updated while count and the Prometheus +Inf bucket were too low. The atomic implementation discarded these observations entirely. Account for the implicit overflow bucket in every implementation, validate that configured boundaries fit the fixed histogram storage, and cover below-boundary, exact-boundary, and overflow observations across all backends and Prometheus output.
xiaoxichen
force-pushed
the
fix/histogram-overflow-bucket
branch
from
September 6, 2026 07:10
797f05d to
2640c9f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Histogram observations above the largest configured boundary use the implicit overflow bucket at index boundaries.size(). RCU and thread-buffer aggregation previously omitted that slot during merge, leaving the sum updated while count and the Prometheus +Inf bucket were too low. The atomic implementation discarded these observations entirely.
Account for the implicit overflow bucket in every implementation, validate that configured boundaries fit the fixed histogram storage, and cover below-boundary, exact-boundary, and overflow observations across all backends and Prometheus output.