Skip to content

[StreamTracker] allow rollback to start-1 - #294

Merged
Besroy merged 1 commit into
eBay:masterfrom
Besroy:allow_rollback_at_start
Feb 5, 2026
Merged

Besroy merged 1 commit into
eBay:masterfrom
Besroy:allow_rollback_at_start

Conversation

@Besroy

@Besroy Besroy commented Feb 3, 2026

Copy link
Copy Markdown
Contributor

Related issue: eBay/HomeStore#857

@codecov-commenter

codecov-commenter commented Feb 3, 2026 •

Copy link
Copy Markdown

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

❌ Patch coverage is 0% with 4 lines in your changes missing coverage. Please review.
✅ Project coverage is 50.44%. Comparing base (370c772) to head (1cc6a31).
⚠️ Report is 86 commits behind head on master.
❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@             Coverage Diff             @@
##           master     #294       +/-   ##
===========================================
- Coverage   64.29%   50.44%   -13.86%     
===========================================
  Files          72       63        -9     
  Lines        4406     4084      -322     
  Branches      555     1774     +1219     
===========================================
- Hits         2833     2060      -773     
+ Misses       1327      868      -459     
- Partials      246     1156      +910     
Components Coverage Δ
AuthManager 55.55% <ø> (-22.23%) ⬇️
Cache 31.52% <54.12%> (+1.58%) ⬆️
FDS 60.57% <21.73%> (-10.55%) ⬇️
FileWatcher 37.60% <20.00%> (-18.65%) ⬇️
Flip ∅ <ø> (∅)
gRPC 56.59% <46.87%> (-20.46%) ⬇️
Logging 27.65% <22.72%> (-2.53%) ⬇️
Metrics 58.77% <63.82%> (-21.43%) ⬇️
Options 25.00% <ø> (-75.00%) ⬇️
Setting 29.62% <ø> (-27.17%) ⬇️
StatusObject 37.16% <ø> (-36.67%) ⬇️
Utility 60.98% <100.00%> (-21.74%) ⬇️
Version 36.00% <ø> (-59.84%) ⬇️
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@Besroy
Besroy force-pushed the allow_rollback_at_start branch from b931e5d to 753f72c Compare February 3, 2026 09:54
Comment thread include/sisl/fds/stream_tracker.hpp Outdated
@Besroy
Besroy force-pushed the allow_rollback_at_start branch from 753f72c to 1cc6a31 Compare February 4, 2026 03:40

@xiaoxichen xiaoxichen left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@Besroy
Besroy merged commit 65b7bec into eBay:master Feb 5, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants