Skip to content

Reduce Raft empty APPEND_ENTRIES heartbeat logs. #918

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Besroy merged 1 commit into from
Sep 18, 2026
Merged

Reduce Raft empty APPEND_ENTRIES heartbeat logs. #918

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion conanfile.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@

class HomestoreConan(ConanFile):
name = "homestore"
version = "7.5.20"
version = "7.5.21"

homepage = "https://github.com/eBay/Homestore"
description = "HomeStore Storage Engine"
Expand Down
4 changes: 4 additions & 0 deletions src/lib/common/homestore_config.fbs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -324,6 +324,10 @@ table Consensus {
// Log frequency for gc_repl_reqs messages (log every N times)
// 60 * repl_dev_cleanup_interval_sec (60s) means every 1 hour we will log the gc repl reqs info.
gc_repl_reqs_log_frequency: uint32 = 60 (hotswap);

// Log frequency for empty APPEND_ENTRIES (heartbeat) "Received no entry" messages (log every N times)
// 14400 * heartbeat_period_ms (250ms) means every 1 hour we will log an empty append.
received_no_entry_log_frequency: uint32 = 14400 (hotswap);
}

table HomeStoreSettings {
Expand Down
4 changes: 2 additions & 2 deletions src/lib/replication/repl_dev/raft_repl_dev.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2368,8 +2368,8 @@ nuraft::cb_func::ReturnCode RaftReplDev::raft_event(nuraft::cb_func::Type type,

auto start_lsn = raft_req->get_last_log_idx() + 1;
if (entries.size() == 0) {
RD_LOGT(NO_TRACE_ID, "Raft channel: Received no entry, leader committed lsn {}",
raft_req->get_commit_idx());
RD_LOGT_EVERY_N(unmove(HS_DYNAMIC_CONFIG(consensus.received_no_entry_log_frequency)), NO_TRACE_ID,
"Raft channel: Received no entry, leader committed lsn {}", raft_req->get_commit_idx());
return ret;
}

Expand Down
Loading