Skip to content

allow homestore consumer to specify chunk_size for more than 4GB (32bit) - #803

Closed
yamingk wants to merge 1 commit into
eBay:masterfrom
yamingk:yk_chunk_size
Closed

yamingk wants to merge 1 commit into
eBay:masterfrom
yamingk:yk_chunk_size

Conversation

@yamingk

@yamingk yamingk commented Sep 10, 2025

Copy link
Copy Markdown
Contributor

No description provided.

@yamingk yamingk closed this Sep 10, 2025
@codecov-commenter

Copy link
Copy Markdown

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

❌ Patch coverage is 88.88889% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 55.30%. Comparing base (1a0cef8) to head (f0b8d71).
⚠️ Report is 264 commits behind head on master.

Files with missing lines Patch % Lines
src/lib/device/device_manager.cpp 75.00% 0 Missing and 1 partial ⚠️
❗ Your organization needs to install the Codecov GitHub app to enable full functionality.
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #803      +/-   ##
==========================================
- Coverage   56.51%   55.30%   -1.22%     
==========================================
  Files         108      110       +2     
  Lines       10300    13254    +2954     
  Branches     1402     1929     +527     
==========================================
+ Hits         5821     7330    +1509     
- Misses       3894     5078    +1184     
- Partials      585      846     +261     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@xiaoxichen

Copy link
Copy Markdown
Collaborator

If we want to do this we need to do it in 7.x

@yamingk

yamingk commented Sep 11, 2025

Copy link
Copy Markdown
Contributor Author

@xiaoxichen Thanks for the comments, when this goes to HomeStore master, I will need to notify the whole team and how we want to merge, like you mentioned to 7.x or some other manner. I am wondering if we goes into 7.x will it be safe that it won't cause any upgrade issues for NuObject V2 track. There is a another way in my mind that only format the disk when we are on NuBlox 2.0 use case, and making this totally transparent to NuObjectV2, but require some handling from homestore side.

Though I like the 7.x idea you brough up which can save a lot of extra effort.

@xiaoxichen

Copy link
Copy Markdown
Collaborator

We also need figuring out how we mange HO build in Github actions by pointing to 6.x , those annoying cache stuff.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants