Skip to content

SDSTOR-18909: Fix bugs in btree merge code - #796

Merged
raakella1 merged 4 commits into
eBay:masterfrom
raakella1:range_remove
Sep 3, 2025
Merged

raakella1 merged 4 commits into
eBay:masterfrom
raakella1:range_remove

Conversation

@raakella1

Copy link
Copy Markdown
Contributor

We are creating empty new nodes during btree merge due to a bug which is causing an assert. Added UT to reproduce the issue and fixed the bug.

@raakella1
raakella1 requested review from sanebay and shosseinimotlagh and removed request for sanebay August 28, 2025 17:33
@codecov-commenter

Copy link
Copy Markdown

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

❌ Patch coverage is 44.73684% with 21 lines in your changes missing coverage. Please review.
✅ Project coverage is 55.48%. Comparing base (1a0cef8) to head (b25c66a).
⚠️ Report is 255 commits behind head on master.

Files with missing lines Patch % Lines
...clude/homestore/btree/detail/btree_remove_impl.ipp 44.73% 17 Missing and 4 partials ⚠️
❗ Your organization needs to install the Codecov GitHub app to enable full functionality.
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #796      +/-   ##
==========================================
- Coverage   56.51%   55.48%   -1.03%     
==========================================
  Files         108      110       +2     
  Lines       10300    13230    +2930     
  Branches     1402     1925     +523     
==========================================
+ Hits         5821     7341    +1520     
- Misses       3894     5043    +1149     
- Partials      585      846     +261     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@JacksonYao287

Copy link
Copy Markdown
Member

@shosseinimotlagh can you review this PR?

@xiaoxichen xiaoxichen left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As we see positive improvement in the testing, lets merge it.

@raakella1
raakella1 merged commit 0e3ea96 into eBay:master Sep 3, 2025
21 checks passed
@raakella1
raakella1 deleted the range_remove branch September 3, 2025 16:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants