Skip to content

support get my repl_svc_port - #348

Merged
Besroy merged 1 commit into
eBay:mainfrom
Besroy:hr_port
Sep 28, 2025
Merged

Besroy merged 1 commit into
eBay:mainfrom
Besroy:hr_port

Conversation

@Besroy

@Besroy Besroy commented Sep 23, 2025

Copy link
Copy Markdown
Contributor

wait until eBay/HomeStore#809 merged

@Besroy
Besroy requested a review from xiaoxichen September 23, 2025 07:04
@Besroy
Besroy force-pushed the hr_port branch 2 times, most recently from 8b0d126 to 95a6f08 Compare September 24, 2025 09:01
xiaoxichen
xiaoxichen previously approved these changes Sep 24, 2025
JacksonYao287
JacksonYao287 previously approved these changes Sep 25, 2025
@codecov-commenter

Copy link
Copy Markdown

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

❌ Patch coverage is 57.14286% with 3 lines in your changes missing coverage. Please review.
✅ Project coverage is 60.55%. Comparing base (1746bcc) to head (37727cd).
⚠️ Report is 122 commits behind head on main.

Files with missing lines Patch % Lines
src/lib/homestore_backend/hs_homeobject.cpp 66.66% 1 Missing and 1 partial ⚠️
src/include/homeobject/homeobject.hpp 0.00% 1 Missing ⚠️
❗ Your organization needs to install the Codecov GitHub app to enable full functionality.
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #348      +/-   ##
==========================================
- Coverage   63.15%   60.55%   -2.61%     
==========================================
  Files          32       35       +3     
  Lines        1900     4343    +2443     
  Branches      204      528     +324     
==========================================
+ Hits         1200     2630    +1430     
- Misses        600     1440     +840     
- Partials      100      273     +173     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@Besroy
Besroy merged commit 5e9dc0d into eBay:main Sep 28, 2025
71 of 73 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants