Skip to content

the chunk should be selected for open shard when recovery - #346

Merged
JacksonYao287 merged 1 commit into
eBay:mainfrom
JacksonYao287:fix-creating-shard
Sep 24, 2025
Merged

JacksonYao287 merged 1 commit into
eBay:mainfrom
JacksonYao287:fix-creating-shard

Conversation

@JacksonYao287

@JacksonYao287 JacksonYao287 commented Sep 22, 2025 •

Copy link
Copy Markdown
Member

in this PR, we select_specific_chunk for all open shard in a specific pg after all the logs are replayed and before joining raft group

@Besroy Besroy left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Could you submit the related HS pr before it merged?

@JacksonYao287

Copy link
Copy Markdown
Member Author

LGTM. Could you submit the related HS pr before it merged?

eBay/HomeStore#806 PTAL

@codecov-commenter

Copy link
Copy Markdown

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

❌ Patch coverage is 65.00000% with 7 lines in your changes missing coverage. Please review.
✅ Project coverage is 59.94%. Comparing base (1746bcc) to head (0590211).
⚠️ Report is 120 commits behind head on main.

Files with missing lines Patch % Lines
...ib/homestore_backend/replication_state_machine.cpp 58.82% 6 Missing and 1 partial ⚠️
❗ Your organization needs to install the Codecov GitHub app to enable full functionality.
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #346      +/-   ##
==========================================
- Coverage   63.15%   59.94%   -3.22%     
==========================================
  Files          32       35       +3     
  Lines        1900     4341    +2441     
  Branches      204      528     +324     
==========================================
+ Hits         1200     2602    +1402     
- Misses        600     1469     +869     
- Partials      100      270     +170     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@JacksonYao287
JacksonYao287 merged commit a6f3fe2 into eBay:main Sep 24, 2025
91 of 99 checks passed
@JacksonYao287
JacksonYao287 deleted the fix-creating-shard branch September 24, 2025 10:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants