Repository navigation
Add generic handle logic for non-data-op - #338
Conversation
| LOGI("pre_commit HS_CTRL_UPDATE_TRUNCATION_BOUNDARY log entry, lsn={}", lsn); | ||
| return true; | ||
| } | ||
|
|
There was a problem hiding this comment.
IIUC the real issue before this commit was homestore::journal_type_t::HS_CTRL_UPDATE_TRUNCATION_BOUNDARY reaches L99 and got NPE somewhere?
Can we cleanup the L80 - L98 like
if (ctx->op_code() != homestore::journal_type_t::HS_DATA_LINKED) && (ctx->op_code() != homestore::journal_type_t::HS_DATA_INLINED) {
LOGI("pre_commit TO_STRING(ctx->op_code()) log entry, lsn={}", lsn);
return true;
}
else {
assert(ctx->op_code() == journal_type_t::HS_DATA_LINKED || ctx->op_code() == journal_type_t::HS_DATA_INLINED);
.....
}
There was a problem hiding this comment.
i am curious why we hit this issue until now. Theoretically, any HS_CTRL_UPDATE_TRUNCATION_BOUNDARY will hit this issue. Don`t we enable UPDATE_TRUNCATION_BOUNDARY in previous tests?
There was a problem hiding this comment.
This PR doesn't fix the crash issue; it simply reduces the log noise from corrupted messages due to unhandled control messages.
Thank you for your comment ! It's a great idea, and I've updated the code
|
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #338 +/- ##
==========================================
- Coverage 63.15% 60.28% -2.88%
==========================================
Files 32 35 +3
Lines 1900 4253 +2353
Branches 204 511 +307
==========================================
+ Hits 1200 2564 +1364
- Misses 600 1424 +824
- Partials 100 265 +165 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This pr avoids the false alarm of corrupted message when HS adds ctrl type log but HO is not updated