Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On 64-bit platforms,
FormatInteger("#.", 9007199254740993)returns9007199254740992. Converting an integer tofloat64loses digits for large values, and the float rounding step can also change an exact integer when no decimal places are requested.This change formats the integer's decimal digits directly and shares the existing format parsing with
FormatFloat. Grouping, signs and decimal zero padding stay the same, including the default two decimal places. Negative values are handled without negating the integer, so the minimumintremains valid. The float rounding and special-value handling are unchanged.The regression tests cover 32-bit and 64-bit boundaries, large positive and negative values, explicit signs, Unicode separators, zero padding and invalid formats. Full tests, build and
go vet ./...pass on Windows with Go 1.21.13 and 1.27.1. The 32-bit Windows suite also passes, skipping the seven values that require a 64-bitint. A separate comparison of 154 float-formatting cases on each Go version matches the unchanged code. Linux CI and race tests were not run locally.