Repository navigation
Symfony 8 removed XmlFileLoader, changed to PhpFileLoader (2) - #158
Conversation
wickedOne
changed the title
20b4e68 to
bfe4ee7
Compare
|
@dunglas tests are green as requested; a merge & release would be highly appreciated |
There was a problem hiding this comment.
Pull request overview
This pull request migrates the bundle's service configuration from XML to PHP format to maintain compatibility with Symfony 8, which removed XmlFileLoader. Additionally, it adds conditional support for Doctrine ORM's enable_native_lazy_objects feature when running on PHP 8.4+ with Doctrine ORM 3.0+.
Key Changes:
- Replaced XML service definitions with PHP-based service configuration using the new Symfony DI format
- Added version detection logic to conditionally enable native lazy objects for PHP 8.4+ with Doctrine ORM 3.0+
- Added
composer/semveras a dev dependency to support version constraint checking
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
src/Bundle/Resources/config/services.xml |
Removed XML service configuration file (deprecated in Symfony 8) |
src/Bundle/Resources/config/services.php |
Added new PHP-based service configuration with equivalent service definitions |
src/Bundle/DependencyInjection/DunglasDoctrineJsonOdmExtension.php |
Updated to use PhpFileLoader instead of XmlFileLoader and load services.php instead of services.xml |
tests/Fixtures/AppKernel.php |
Added conditional configuration for enable_native_lazy_objects based on PHP and Doctrine ORM versions |
composer.json |
Added composer/semver ^3.4 to dev dependencies for version constraint checking |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 5 out of 5 changed files in this pull request and generated 2 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 5 out of 5 changed files in this pull request and generated no new comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
Thank you |
|
@dunglas any chance this can get a release or are there any other issues that need to be resolved first? |
|
Ping @dunglas, this dependency is the last one holding back a Symfony 8 upgrade on some of my projects 😄 |
hijacking #156 from @iksmail (can't push to his main branch) in order to fix the test suite.
enables the
enable_native_lazy_objectsconfig value when php version >= 8.4.0 and doctrine/orm ^3.0