This repository was archived by the owner on Mar 26, 2020. It is now read-only.
Change djinni's generated Java files to use interfaces#406
Open
ggdabuh wants to merge 1 commit into
Open
Conversation
Contributor
|
To be clear for readers, is about using abstract interfaces for generated container types like list and map when used in records, arguments, and returns. This isn't about what Djinni calls interfaces. A few procedural things:
|
|
Hi, @ggdabuh: |
Contributor
|
This repo isn't going to be adding any new features so I'm putting this PR on hold. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request is related to #390.
The idea is to use interfaces rather that classes as, anyway, the marshaling layer is ready for that.
This is a breaking change since users will need to update their overrides.