This repository was archived by the owner on Mar 26, 2020. It is now read-only.
Property declaration support in interfaces#360
Conversation
… only the getter in this instance.
- Update the AST to reuse method generation logic for producing accessor methods - Add a non-static method within parameter declarations to prove it works - Updated test implementation
|
Hi, @MikeNachbaur: |
xianwen
suggested changes
Jul 17, 2018
xianwen
left a comment
xianwen
left a comment
There was a problem hiding this comment.
Hi, @MikeNachbaur:
I noticed you haven't signed the CLA yet, could you please sign it here: https://opensource.dropbox.com/cla/
Thanks a lot!
shahzadlone
reviewed
Jan 31, 2019
| try { | ||
| DJINNI_FUNCTION_PROLOGUE1(jniEnv, nativeRef); | ||
| const auto& ref = ::djinni::objectFromHandleAddress<::testsuite::PropertiesTestHelper>(nativeRef); | ||
| auto r = ref->other_method(::djinni::String::toCpp(jniEnv, j_argument)); |
Contributor
There was a problem hiding this comment.
Does r get modified? if not prefer to use const here.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In an effort to continue the work in this PR #287, I've attempted to address the review comments and ensure the concerns have been addressed. Please review that original PR for more details.
Wherever possible I attempted to inject property-specific accessor information into the methods AST to share code generation. I was unable to do this at the parser level, since different languages have different needs.