This repository was archived by the owner on Mar 26, 2020. It is now read-only.
Added support for constexpr for primitives in header files#354
Merged
Conversation
* Got a basic version of constexpr in headers working * got enum values to work as well * can't do enums because interface headers forward declare so you can't set it there. So only primitives allowed * fixing const enums in obj-c, which apparently never worked to begin with
|
Hi, Alan: Thanks a lot! |
xianwen
approved these changes
Mar 30, 2018
xianwen
left a comment
xianwen
left a comment
There was a problem hiding this comment.
LGTM, and all tests passed. Once you signed CLA, I can merge it into master. Thanks!
Contributor
Author
|
I think I just signed it so we should be good to go now :-) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The problem here is that if you have a record of const ints, for example a record of error codes, you can not switch case them as the values are not set in the header. This PR adds constexpr support for const primitives in header files so that this is doable. It also fixes const enum values in Objective C, which appeared to never have been working.
It excludes optional primitives as they might not support constexpr (if using things like boost optional)
(It is based off PR #282 which appears to have been abandoned)
Got a basic version of constexpr in headers working
got enum values to work as well
can't do enums because interface headers forward declare so you can't set it there. So only primitives allowed
fixing const enums in obj-c, which apparently never worked to begin with