This repository was archived by the owner on Mar 26, 2020. It is now read-only.
Silence some optional Xcode 9 warnings#348
Open
steipete wants to merge 2 commits into
Open
Conversation
artwyman
suggested changes
Jan 13, 2018
artwyman
left a comment
artwyman
left a comment
Contributor
There was a problem hiding this comment.
See my comment on the exception name for the proposed change. Otherwise this looks great, thanks.
|
|
||
| #define DJINNI_TRANSLATE_EXCEPTIONS() \ | ||
| catch (const std::exception & e) { \ | ||
| catch (__unused const std::exception & e) { \ |
Contributor
There was a problem hiding this comment.
Wouldn't it be better to simply delete the name? It is truly unused, and removing the name is a more standard way to do it in C++.
| struct Boxed { | ||
| using ObjcType = NSNumber*; | ||
| static CppType toCpp(ObjcType x) noexcept { assert(x); return Bool::toCpp([x boolValue]); } | ||
| static CppType toCpp(ObjcType x) noexcept { assert(x != nil); return Bool::toCpp([x boolValue]); } |
Contributor
There was a problem hiding this comment.
Interesting. Stylistically I generally do prefer to let pointers be treated as bools directly, but in this context I'm fine with changing the code to be more generally usable by people who don't like that style and turn on warnings against it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes an Analyzer warning that shows up in Xcode 9:
https://github.com/llvm-mirror/clang/blob/master/test/Analysis/number-object-conversion.cpp
Also fixes an optional warning:
The
__unusedon the exception is needed when-Wunused-exception-parameteris enabled.Both are trivial changes that do not change functionality.
Thanks for making Djinni! We from PSPDFKit love it!