Skip to content

fix(network): don't show a saved SSID when Wi-Fi is disconnected on macOS #397

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ykworx wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix(network): don't show a saved SSID when Wi-Fi is disconnected on macOS #397

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions scripts/network.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,6 +41,16 @@ get_ssid()

ifname=$(_get_wifi_ifname)

# Only report a Wi-Fi network when the interface is actually associated. Otherwise the
# fallback below can surface a saved/preferred SSID (listpreferredwirelessnetworks) and
# show a stale name -- e.g. an old hotspot -- whenever Wi-Fi is off but the machine is
# online via Ethernet. Association state stays readable even though the SSID itself is
# gated behind Location Services on macOS 15+.
if [[ "$(ifconfig "$ifname" 2>/dev/null | awk '/status:/ {print $2}')" != "active" ]]; then
echo "$ethernet_label"
return
fi

# string manipulation required to remove the minor version of the macos version (e.g. x.y.z removes .z)
# this is required to prevent issues in version detection
#
Expand Down