Make the program XDG compliant#124
Open
S0AndS0 wants to merge 1 commit into
Open
Conversation
Fix dpnkrpl#105 and add `fallback` for all undefined configuration entries **Attributions** - [Github `deep5050/radio-active` -- Issue: Make the program XDG compliant](dpnkrpl#105) - [GitHub `takluyver/pyxdg` -- `xdg/BaseDirectory.py`](https://github.com/takluyver/pyxdg/blob/aba9d73c1e41f58234988bd155fe67ef7cb0fae0/xdg/BaseDirectory.py#L37-L41) - `python3-3.13.6/lib/python3.13/configparser.py` ``` read(filenames, encoding=None) Read and parse the iterable of named configuration files, given by name. A single filename is also allowed. Non-existing files are ignored. Return list of successfully read files. ```
|
Hi, @S0AndS0, By that time enjoy this meme 👇 , hope you like it 😄  Use this action on your projects. Use jokes on issues instead. |
S0AndS0
added a commit
to S0AndS0/nixpkgs
that referenced
this pull request
Sep 13, 2025
Internally adds `zenlog` which, in the future, may break due to `colorlog` introducing breaking-changes. Hence why for the commented code in that section. Searching if any other packages have this dependency did not result in results; ```bash shopt -s globstar; grep -rEn -- zenlog pkgs/**/*.nix; ``` Overrides and pins `pyradios` to version `1.0.2` because without this the main application complains during install time. Main package `src` is obtained via `fetchFromGitHub` because I forked it to enable XDG configuration directory support as well as reduce need of declaring defaults. Once dpnkrpl/radio-active#124 is accepted, or rejected, we can revisit the `src` value. Attributions; - @qzylinra for making code look pretty - @SuperSandro2000 for encouraging `zenlog` to be packaged separately
Owner
|
let me take a look now.. sorry for the delay |
Merged
Owner
|
@all-contributors please add @S0AndS0 for the bug code |
Contributor
|
I've put up a pull request to add @S0AndS0! 🎉 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #105 and add
fallbackfor all undefined configuration entriesThis set of changes should be backwards compatible, because it'll still read from
~/.radio-active-configs.iniAttributions
deep5050/radio-active-- Issue: Make the program XDG complianttakluyver/pyxdg--xdg/BaseDirectory.pypython3-3.13.6/lib/python3.13/configparser.py