Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is ultimately to allow tui-term to build on ESP32 (or other embedded environments).
For the most part, this is accomplished simply by replacing
stdreferences withcoreorallocreferences as appropriate.The only functionality which is only available in
stdis theWritetrait, which I've gated behind anstddefault feature flag.The only dependency which requires
stdisvte, which itself has anstddefault feature flag, which I've made conditional on thestdflag in this crate.I also added a flag and matching optional dependency on the
embedded-iocrate, which provides its ownWritetrait suitable for use in no_std embedded environments. (This is not necessary for no_std, but nice to have.)Modified the
writetests to use the appropriate trait (or not run). Here there is one infelicity: if bothstdandembedded-iofeatures are requested, the tests only run for thestdWritetraits. I don't know a clean way to parameterize them (short of a pile of macros), and it's unlikely someone will enable both these features simultaneously.Finally, bumped the version to 0.16.3.