Repository navigation
Conversation
…ays instead of lists
Contributor
✅ Release notes checked
|
DedSec256
marked this pull request as ready for review
October 27, 2026 18:47
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ProjectSnapshotBasestored its source files and referenced projects as lists. The TransparentCompiler usually needs them as arrays, so the code kept converting back and forth:LoadSources,parseSourceFiles,parseSourceFilesExceptImplFilesWithSignatures,FromOptions,GetProjectSnapshotFromScript) gets an array fromMultipleDiagnosticsLoggers.Paralleland turned it into a list withArray.toList.parseSourceFilesExceptImplFilesWithSignaturesthen turned it back withList.toArray.ComputeTcIntermediateand theArtificialImplFilebranch ofprocessGraphNoderead the file by index,projectSnapshot.SourceFiles[index]. On a list each read walks the list, which makes type checking a project quadratic in its file count.List.last,.LengthandList.tryItemare used in several places.This PR makes
sourceFilesandreferencedProjectsarrays.Breaking change (experimental API)
The public surface of
FSharpProjectSnapshotchanges:SourceFiles: FSharpFileSnapshot[]ReferencedProjects: FSharpReferencedProjectSnapshot[]Create(..., sourceFiles: FSharpFileSnapshot[], ..., referencedProjects: FSharpReferencedProjectSnapshot[], ...)Replace(changedSourceFiles: FSharpFileSnapshot[])The API is marked
[<Experimental>]. Callers have to pass and consume arrays instead of lists. The surface area baseline is updated.