Skip to content

Add a refactoring between ?x and [<Struct>] ?x optional parameters #20546

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
xperiandri wants to merge 9 commits into
base: main
Choose a base branch
from
+1,238 −0
Open

Add a refactoring between ?x and [<Struct>] ?x optional parameters #20546

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
e657e4f
Add a refactoring between option and struct optional member parameters
xperiandri Sep 14, 2026
90f3a58
Add the optional parameter refactoring titles to the xlf files
xperiandri Sep 14, 2026
bb3b002
Write the optional parameter test code as multi-line strings
xperiandri Sep 14, 2026
ef1fbcf
Link the release note to the pull request and move it to a random lin…
xperiandri Sep 14, 2026
24db93d
Resolve option cases and functions by symbol before renaming them
xperiandri Sep 29, 2026
7dd5932
Keep the optional parameter conversion from changing what the code means
xperiandri Oct 11, 2026
120090b
Name the optional parameter conversion steps instead of commenting them
xperiandri Oct 15, 2026
df9e242
Parameterize the optional parameter conversion tests
xperiandri Oct 15, 2026
829ccb7
Bring the rebased branch to what it had before the rebase
xperiandri Oct 29, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions docs/release-notes/.VisualStudio/18.vNext.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@

* Suggest active-pattern cases from unopened modules and offer valid Add Open and qualification edits. ([PR #20719](https://github.com/dotnet/fsharp/pull/20719))
* Add maintainer-requested F# Apex Visual Studio integration tests on DartLab-1ES CloudTest, using PR pipeline definitions pinned to an explicitly requested commit SHA. ([PR #20625](https://github.com/dotnet/fsharp/pull/20625))
* Refactoring to switch a member's optional parameter between `?x` (`option`) and `[<Struct>] ?x` (`voption`), rewriting `defaultArg`, `Option` functions and `match` cases on it in the body and `?x = value` arguments at its call sites in the solution. ([PR #20546](https://github.com/dotnet/fsharp/pull/20546))
* Code-fixes for FS3888 (compiler-semantic attribute on the `.fs` but not the `.fsi`): copy the attribute into the `.fsi`, or remove it from the `.fs`. ([Issue #19560](https://github.com/dotnet/fsharp/issues/19560), [PR #19880](https://github.com/dotnet/fsharp/pull/19880))
* Expand `<inheritdoc/>` in IDE tooltips, completion, and signature help, inheriting XML documentation from base classes, interfaces, overridden members, and constructors. ([Issue #19175](https://github.com/dotnet/fsharp/issues/19175), [PR #19188](https://github.com/dotnet/fsharp/pull/19188))
* Added a **Tools > Options > F# Tools > Compiler** option, **"Use the .NET SDK F# compiler for builds"**, on by default. Visual Studio uses the .NET SDK F# compiler when the project supplies SDK paths, matching `dotnet build`. Otherwise, it uses the bundled .NET Framework compiler. Turn the option off to use the bundled compiler for all projects. Changes are saved on Apply or OK; Cancel discards unsaved changes. Command-line builds are unaffected. ([Issue #20484](https://github.com/dotnet/fsharp/issues/20484), [PR #20485](https://github.com/dotnet/fsharp/pull/20485))
Expand Down
1 change: 1 addition & 0 deletions vsintegration/src/FSharp.Editor/FSharp.Editor.fsproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -109,6 +109,7 @@
<Compile Include="Refactor\ChangeTypeofWithNameToNameofExpression.fs" />
<Compile Include="Refactor\AddExplicitTypeToParameter.fs" />
<Compile Include="Refactor\ChangeDerefToValueRefactoring.fs" />
<Compile Include="Refactor\ConvertOptionalParameterStruct.fs" />
<Compile Include="CodeFixes\IFSharpCodeFix.fs" />
<Compile Include="CodeFixes\CodeFixHelpers.fs" />
<Compile Include="CodeFixes\ChangeEqualsInFieldTypeToColon.fs" />
Expand Down
6 changes: 6 additions & 0 deletions vsintegration/src/FSharp.Editor/FSharp.Editor.resx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -373,4 +373,10 @@ Use live (unsaved) buffers for analysis</value>
{2}</value>
<comment>Tooltip of an F# declaration in the Copilot Chat "#" picker, as Copilot shows a C# one. {0} is the kind of declaration (Class, Method, Field...), {1} the file name, {2} the declaration's name.</comment>
</data>
<data name="UseValueOptionForOptionalParameter" xml:space="preserve">
<value>Use 'voption' for optional parameter</value>
</data>
<data name="UseOptionForOptionalParameter" xml:space="preserve">
<value>Use 'option' for optional parameter</value>
</data>
</root>
Loading
Loading