Skip to content

Validate LatencyPlugin minMs <= maxMs at startup #1982

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
waldekmastykarz merged 1 commit into from
Oct 26, 2026
Merged

Validate LatencyPlugin minMs <= maxMs at startup #1982

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
41 changes: 41 additions & 0 deletions DevProxy.Integration.Tests/BehaviorPluginsIntegrationTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -239,6 +239,47 @@ public void Latency_DelayRangeIncludesMaxMs()
Assert.InRange(LatencyPlugin.GetDelay(random, int.MaxValue - 1, int.MaxValue), int.MaxValue - 1, int.MaxValue);
}

[Fact]
public async Task Latency_InitializeFailsWhenMinMsGreaterThanMaxMs()
{
var config = PluginConfig.FromJson("""
{ "minMs": 500, "maxMs": 100 }
""");
var plugin = new LatencyPlugin(
SharedHttpClient,
NullLogger<LatencyPlugin>.Instance,
KestrelProxyHarness.BuildUrlsToWatch("localhost"),
ProxyConfig,
config);

using var host = new PluginTestHost(ProxyConfig);
var ex = await Assert.ThrowsAsync<InvalidOperationException>(
() => plugin.InitializeAsync(host.CreateInitArgs(), CancellationToken.None));

Assert.Contains("minMs (500)", ex.Message, StringComparison.Ordinal);
Assert.Contains("maxMs (100)", ex.Message, StringComparison.Ordinal);
Assert.False(plugin.Enabled);
}

[Fact]
public async Task Latency_InitializeSucceedsWhenMinMsEqualsMaxMs()
{
var config = PluginConfig.FromJson("""
{ "minMs": 100, "maxMs": 100 }
""");
var plugin = new LatencyPlugin(
SharedHttpClient,
NullLogger<LatencyPlugin>.Instance,
KestrelProxyHarness.BuildUrlsToWatch("localhost"),
ProxyConfig,
config);

using var host = new PluginTestHost(ProxyConfig);
await plugin.InitializeAsync(host.CreateInitArgs(), CancellationToken.None);

Assert.True(plugin.Enabled);
}

[Fact]
public async Task RateLimiting_ThrottlesOnceResourcesAreExhausted()
{
Expand Down
11 changes: 11 additions & 0 deletions DevProxy.Plugins/Behavior/LatencyPlugin.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,6 +32,17 @@ public sealed class LatencyPlugin(

public override string Name => nameof(LatencyPlugin);

public override async Task InitializeAsync(InitArgs e, CancellationToken cancellationToken)
{
await base.InitializeAsync(e, cancellationToken);

if (Configuration.MinMs > Configuration.MaxMs)
{
Enabled = false;
throw new InvalidOperationException($"{Name}: minMs ({Configuration.MinMs}) must be less than or equal to maxMs ({Configuration.MaxMs}).");
}
}

// HTTP: Add latency before request is forwarded
public override async Task BeforeRequestAsync(ProxyRequestArgs e, CancellationToken cancellationToken)
{
Expand Down
Loading