Skip to content

Fix Java-generic name-clash in AdLoadCallback subclasses (issue #1491) #1492

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jonathanpeppers merged 3 commits into from
Jul 2, 2026
Merged

Fix Java-generic name-clash in AdLoadCallback subclasses (issue #1491) #1492

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
76b99a6
Fix Java-generic name-clash in AdLoadCallback subclasses (issue #1491)
jonathanpeppers Jul 1, 2026
0117a9d
Bump Xamarin.GooglePlayServices.Ads.Lite to 124.0.0.7
jonathanpeppers Jul 1, 2026
66c0f36
Extend AdLoadCallback fix to play-services-ads-api (issue #1491)
jonathanpeppers Jul 1, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions source/com.google.android.gms/play-services-ads-lite/PublicAPI/PublicAPI.Unshipped.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1336,6 +1336,7 @@ virtual Android.Gms.Ads.AdLoader.IsLoading.get -> bool
virtual Android.Gms.Ads.AdLoader.LoadAd(Android.Gms.Ads.AdManager.AdManagerAdRequest! adManagerAdRequest) -> void
virtual Android.Gms.Ads.AdLoader.LoadAd(Android.Gms.Ads.AdRequest! adRequest) -> void
virtual Android.Gms.Ads.AdLoader.LoadAds(Android.Gms.Ads.AdRequest! adRequest, int maxNumberOfAds) -> void
virtual Android.Gms.Ads.AdManager.AdManagerInterstitialAdLoadCallback.OnAdLoaded(Android.Gms.Ads.AdManager.AdManagerInterstitialAd! p0) -> void
virtual Android.Gms.Ads.AdRequest.AdString.get -> string?
virtual Android.Gms.Ads.AdRequest.Builder.Build() -> Android.Gms.Ads.AdRequest!
virtual Android.Gms.Ads.AdRequest.ContentUrl.get -> string!
Expand All @@ -1346,6 +1347,7 @@ virtual Android.Gms.Ads.AdRequest.IsTestDevice(Android.Content.Context! context)
virtual Android.Gms.Ads.AdRequest.Keywords.get -> System.Collections.Generic.ICollection<string!>!
virtual Android.Gms.Ads.AdRequest.NeighboringContentUrls.get -> System.Collections.Generic.IList<string!>!
virtual Android.Gms.Ads.AdRequest.RequestAgent.get -> string!
virtual Android.Gms.Ads.AppOpen.AppOpenAd.AppOpenAdLoadCallback.OnAdLoaded(Android.Gms.Ads.AppOpen.AppOpenAd! p0) -> void
virtual Android.Gms.Ads.BaseAdView.AdListener.get -> Android.Gms.Ads.AdListener!
virtual Android.Gms.Ads.BaseAdView.AdListener.set -> void
virtual Android.Gms.Ads.BaseAdView.AdSize.get -> Android.Gms.Ads.AdSize?
Expand All @@ -1369,6 +1371,7 @@ virtual Android.Gms.Ads.FullScreenContentCallback.OnAdDismissedFullScreenContent
virtual Android.Gms.Ads.FullScreenContentCallback.OnAdFailedToShowFullScreenContent(Android.Gms.Ads.AdError! p0) -> void
virtual Android.Gms.Ads.FullScreenContentCallback.OnAdImpression() -> void
virtual Android.Gms.Ads.FullScreenContentCallback.OnAdShowedFullScreenContent() -> void
virtual Android.Gms.Ads.Interstitial.InterstitialAdLoadCallback.OnAdLoaded(Android.Gms.Ads.Interstitial.InterstitialAd! p0) -> void
virtual Android.Gms.Ads.Mediation.Adapter.LoadAppOpenAd(Android.Gms.Ads.Mediation.MediationAppOpenAdConfiguration! p0, Android.Gms.Ads.Mediation.IMediationAdLoadCallback! callback) -> void
virtual Android.Gms.Ads.Mediation.Adapter.LoadBannerAd(Android.Gms.Ads.Mediation.MediationBannerAdConfiguration! p0, Android.Gms.Ads.Mediation.IMediationAdLoadCallback! callback) -> void
virtual Android.Gms.Ads.Mediation.Adapter.LoadInterstitialAd(Android.Gms.Ads.Mediation.MediationInterstitialAdConfiguration! p0, Android.Gms.Ads.Mediation.IMediationAdLoadCallback! callback) -> void
Expand Down Expand Up @@ -1454,8 +1457,10 @@ virtual Android.Gms.Ads.RequestConfiguration.TagForChildDirectedTreatment.get ->
virtual Android.Gms.Ads.RequestConfiguration.TagForUnderAgeOfConsent.get -> int
virtual Android.Gms.Ads.RequestConfiguration.TestDeviceIds.get -> System.Collections.Generic.IList<string!>!
virtual Android.Gms.Ads.RequestConfiguration.ToBuilder() -> Android.Gms.Ads.RequestConfiguration.Builder!
virtual Android.Gms.Ads.Rewarded.RewardedAdLoadCallback.OnAdLoaded(Android.Gms.Ads.Rewarded.RewardedAd! p0) -> void
virtual Android.Gms.Ads.Rewarded.ServerSideVerificationOptions.CustomData.get -> string!
virtual Android.Gms.Ads.Rewarded.ServerSideVerificationOptions.UserId.get -> string!
virtual Android.Gms.Ads.RewardedInterstitial.RewardedInterstitialAdLoadCallback.OnAdLoaded(Android.Gms.Ads.RewardedInterstitial.RewardedInterstitialAd! p0) -> void
virtual Android.Gms.Ads.VersionInfo.MajorVersion.get -> int
virtual Android.Gms.Ads.VersionInfo.MicroVersion.get -> int
virtual Android.Gms.Ads.VersionInfo.MinorVersion.get -> int
Expand Down
56 changes: 56 additions & 0 deletions source/com.google.android.gms/play-services-ads-lite/Transforms/Metadata.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -127,6 +127,62 @@
<parameter name="bundle" type="android.os.Bundle"></parameter>
</method>
</add-node>

<!--
Java-generics erasure fix for AdLoadCallback<AdT> subclasses (issue #1491).

The base class:
public abstract class AdLoadCallback<AdT> {
public void onAdLoaded(AdT ad) { }
}
only declares the erased `onAdLoaded(Object)` in bytecode, so the binding
generator exposes it as `virtual OnAdLoaded(Java.Lang.Object p0)` on every
concrete subclass (AdManagerInterstitialAdLoadCallback, InterstitialAdLoadCallback,
etc.).

When a user overrides that in C#, the generated Java ACW stub emits
`public void onAdLoaded(java.lang.Object p0)`. From javac's point of view
the parent (after generic substitution) declares
`onAdLoaded(AdManagerInterstitialAd)`, and the two methods have the same
erasure but neither overrides the other — javac reports a name-clash and
the app fails to build.

Fix: for each concrete subclass, add a specialized `onAdLoaded(SpecificAd)`
method via <add-node>. That surfaces a properly-typed
`virtual OnAdLoaded(SpecificAd p0)` in C# with a specialized JNI
registration, so users' ACW stubs emit the specialized signature that
correctly overrides the parent. This matches how Google's own docs show
the callback being overridden in Java.
-->
<add-node path="/api/package[@name='com.google.android.gms.ads.admanager']/class[@name='AdManagerInterstitialAdLoadCallback']">
<method abstract="false" deprecated="not deprecated" final="false" name="onAdLoaded" native="false" return="void" static="false" synchronized="false" visibility="public" bridge="false" synthetic="false" jni-signature="(Lcom/google/android/gms/ads/admanager/AdManagerInterstitialAd;)V" jni-return="V">
<parameter name="p0" type="com.google.android.gms.ads.admanager.AdManagerInterstitialAd" not-null="true"></parameter>
</method>
</add-node>

<add-node path="/api/package[@name='com.google.android.gms.ads.interstitial']/class[@name='InterstitialAdLoadCallback']">
<method abstract="false" deprecated="not deprecated" final="false" name="onAdLoaded" native="false" return="void" static="false" synchronized="false" visibility="public" bridge="false" synthetic="false" jni-signature="(Lcom/google/android/gms/ads/interstitial/InterstitialAd;)V" jni-return="V">
<parameter name="p0" type="com.google.android.gms.ads.interstitial.InterstitialAd" not-null="true"></parameter>
</method>
</add-node>

<add-node path="/api/package[@name='com.google.android.gms.ads.rewarded']/class[@name='RewardedAdLoadCallback']">
<method abstract="false" deprecated="not deprecated" final="false" name="onAdLoaded" native="false" return="void" static="false" synchronized="false" visibility="public" bridge="false" synthetic="false" jni-signature="(Lcom/google/android/gms/ads/rewarded/RewardedAd;)V" jni-return="V">
<parameter name="p0" type="com.google.android.gms.ads.rewarded.RewardedAd" not-null="true"></parameter>
</method>
</add-node>

<add-node path="/api/package[@name='com.google.android.gms.ads.rewardedinterstitial']/class[@name='RewardedInterstitialAdLoadCallback']">
<method abstract="false" deprecated="not deprecated" final="false" name="onAdLoaded" native="false" return="void" static="false" synchronized="false" visibility="public" bridge="false" synthetic="false" jni-signature="(Lcom/google/android/gms/ads/rewardedinterstitial/RewardedInterstitialAd;)V" jni-return="V">
<parameter name="p0" type="com.google.android.gms.ads.rewardedinterstitial.RewardedInterstitialAd" not-null="true"></parameter>
</method>
</add-node>

<add-node path="/api/package[@name='com.google.android.gms.ads.appopen']/class[@name='AppOpenAd.AppOpenAdLoadCallback']">
<method abstract="false" deprecated="not deprecated" final="false" name="onAdLoaded" native="false" return="void" static="false" synchronized="false" visibility="public" bridge="false" synthetic="false" jni-signature="(Lcom/google/android/gms/ads/appopen/AppOpenAd;)V" jni-return="V">
<parameter name="p0" type="com.google.android.gms.ads.appopen.AppOpenAd" not-null="true"></parameter>
</method>
</add-node>


<attr
Expand Down