Repository navigation
Conversation
(cherry picked from commit ed742c6b585d2bf7e736759c7a08d8f7fe71de08)
…by CI)" This reverts commit 127c3de.
…modules need more specific handling Their build system might rely on git history, etc.
(cherry picked from commit 75bada7)
Probably explains why it didn't work doesn't it
…tifact (cherry picked from commit 9b76580)
…ssing artifact" This reverts commit f69e6bd.
(cherry picked from commit 8098981)
(cherry picked from commit 80fe34c)
Still untested though.
| # Privileged - Must not execute untrusted code | ||
| # We can't let the untrusted job output the PR number | ||
| # and `github.event.workflow_run.pull_requests[0].number` doesn't work | ||
| prNumber: |
There was a problem hiding this comment.
Note to self: There's no point splitting the job here since this workflow uses the workflow file from the PR branch anyway. Ideally we find some other way of retrieving the PR number, but I kinda doubt it when GitHub's own examples show this pattern.
Edit: Really don't like letting untrusted code decide the PR number so I'll fallback to calling the gh api in the trusted workflow instead if I can't find anything else.
https://docs.github.com/en/actions/reference/workflows-and-actions/events-that-trigger-workflows#workflow_run:

There was a problem hiding this comment.
I ended up keeping the job separate due to a different reason (the matrix strategy means there are two jobs for generating the comment now, so the separate job avoids uploading it twice).
I also added some additional validation on the workflow_run end to verify that the number is in fact a number and that the PR's head commit is the expected commit. This means this is now secure.
Perksey
left a comment
There was a problem hiding this comment.
Basically approved, just one teeny comment
| submodules: false | ||
| path: repo | ||
|
|
||
| - name: Identify native job dependencies |
There was a problem hiding this comment.
Same feedback as other PR wrt matrices to deduplicate.
There was a problem hiding this comment.
Matrix has been implemented
… are workflow scripts
…re handled centrally now
Perksey
left a comment
There was a problem hiding this comment.
I have no qualms other than the Silk.NET instead of Silk thing discussed in the Discord.
This reverts commit 9191d8c.
Summary of the PR
This PR contains the first half of the changes related to implementing a PR comment-based native/bindings workflow. Specifically, this expands the PowerShell scripts to handle command parsing, job matrix generation, dependency calculation, and reminder comment generation. It also includes a workflow that triggers on
pull_requestsynchronizethat checks the PR for changes to native builds or bindings and posts a reminder comment whenever the PR makes changes that might affect them.Related issues, Discord discussions, or proposals
This should be merged before the second half of this PR: #2634
Further Comments
Testing Fork
This PR was tested in my fork here:
Exanite-Dev#5
Exanite-Dev#3
Exanite-Dev#2
Tasks
Copied from elsewhere
Native/bindings regeneration workflows (from tracker):
pull_requesttriggerNative/bindings regeneration workflows (from #2628; may duplicate with above):
Added during this PR
Setup dependenciesfrommainbranch native/bindings workflows to a script here to be merged intodevelop/3.0.