Skip to content

Document SQL parameter name simplification as a low-impact breaking change in EF Core 10#5406

Open
Copilot wants to merge 2 commits into
mainfrom
copilot/document-breaking-change-10
Open

Document SQL parameter name simplification as a low-impact breaking change in EF Core 10#5406
Copilot wants to merge 2 commits into
mainfrom
copilot/document-breaking-change-10

Conversation

Copilot AI commented Jun 30, 2026

Copy link
Copy Markdown
Contributor

dotnet/efcore#35200 simplified generated SQL parameter names (dropping the __ prefix and trailing counter), which was not yet captured in the EF Core 10 breaking changes page.

Changes

  • Summary table: Added a SQL parameter names are now simplified row (Low impact) to entity-framework/core/what-is-new/ef-core-10.0/breaking-changes.md.
  • New section: Added the corresponding Old behavior / New behavior / Why / Mitigations entry. Mitigations note this is transparent except for code depending on exact parameter names (SQL snapshot tests, interceptors/loggers parsing CommandText or ParameterName).

Behavior documented

-- Before
@__city_0='London'
WHERE [b].[City] = @__city_0

-- After
@city='London'
WHERE [b].[City] = @city

Note

The issue referenced for context (efcore#38478) is an unrelated NuGet version-mismatch bug report; the content here is based on PR #35200 and the existing whatsnew.md entry describing the @__city_0@city change. The section cites the PR rather than that issue.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Documents an EF Core 10 low-impact breaking change where generated SQL parameter names are simplified (e.g., @__city_0@city) so that the breaking changes page matches the behavior introduced in dotnet/efcore#35200.

Changes:

  • Added a new “SQL parameter names are now simplified” entry to the EF Core 10 breaking changes summary table (Low impact).
  • Added a full breaking-change section describing old/new behavior, rationale, and mitigations for code that depends on exact parameter names.

Comment thread entity-framework/core/what-is-new/ef-core-10.0/breaking-changes.md Outdated
Comment thread entity-framework/core/what-is-new/ef-core-10.0/breaking-changes.md Outdated
Comment thread entity-framework/core/what-is-new/ef-core-10.0/breaking-changes.md
Copilot AI requested a review from AndriySvyryd June 30, 2026 20:29
@AndriySvyryd AndriySvyryd marked this pull request as ready for review June 30, 2026 21:05

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants