You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
These are tests that we're marking as Successful, however they do not match the expected output in some way. This is due to small differences, such as different wording on the error messages, or the column names being incorrect while the data itself is correct. ↩
The reason will be displayed to describe this comment to others. Learn more.
(minor) You may want to add an EXPLAIN SELECT test here, too. Otherwise we aren't testing that this is actually using the index during the join, which I think is what you want to test here.
The reason will be displayed to describe this comment to others. Learn more.
(minor) Looks like these are only used in the pgcatalog package, so you could lower case them to avoid exporting them to all packages. Not a huge deal, but always nice to keep things package private if possible and avoid those symbols being available in other packages if they aren't needed yet.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds the two internal indices that should exist on
pg_type. Very similar to the existing implementation ofpg_class.