Improve gmmain_lib match#2751
Merged
ribbanya merged 2 commits intoJun 22, 2026
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Improves the match for
gmMainLib_8015DBF4by preserving the separate load/store expressions and local pointer lifetimes needed for the mode-record loops. No behavior change is intended.Verification
ninja build/GALE01/src/melee/gm/gmmain_lib.o build/GALE01/report.jsonobjdiff-cli:gmMainLib_8015DBF4improved from 59.6541% to 94.402794% with an exact 3724/3724-byte size