Upgrade CouchDB and prometheus export to newer versions; adjust aux files#1641
Upgrade CouchDB and prometheus export to newer versions; adjust aux files#1641vkuznet wants to merge 2 commits intodmwm:masterfrom
Conversation
amaltaro
left a comment
amaltaro
left a comment
There was a problem hiding this comment.
@vkuznet I left a few comments along the code.
In addition, let us please not merge this until we can verify that CouchDB works well - AND that manage script is still functional, explicitly:
- we can run couchapp to deploy WMCore code
- we can run status/stop/start/restart (for this, I think a restart/stop will kill the container, but that is another problem...)
Thanks!
| # - option A: install with (potential) break of system packages | ||
| # RUN pip install --break-system-packages CMSCouchapp | ||
| # - option B: install in virtual environment | ||
| RUN apt install -y python3.11-venv |
There was a problem hiding this comment.
Why python3.11? Is it the base python version that gets installed with apt-get?
BTW, do we still have to install python? Or does it come with the CouchDB vanilla image?
| RUN curl -ksLO https://github.com/gesellix/couchdb-prometheus-exporter/releases/download/v27.0.0/couchdb-prometheus-exporter_27.0.0_Linux_x86_64.tar.gz | ||
| RUN tar xfz couchdb-prometheus-exporter_27.0.0_Linux_x86_64.tar.gz | ||
| RUN rm couchdb-prometheus-exporter_27.0.0_Linux_x86_64.tar.gz LICENSE README*.md | ||
| ARG VER=30.14.0 |
There was a problem hiding this comment.
I would suggest moving this argument variable to the top of the file and rename it to a more meaningful name (EXPORTER_VER ?).
|
|
||
| # start couchdb exporter | ||
| COUCH_CONFIG=/data/srv/current/auth/couchdb/couchdb_config.ini | ||
| export COUCHDB_NODE_NAME="couchdb@$(hostname)" |
There was a problem hiding this comment.
Why are you removing this line? Do you have to rebase this branch?
| nohup couchdb-prometheus-exporter -telemetry.address=":9984" -logtostderr=true \ | ||
| --config=$COUCH_CONFIG -databases.views=false --databases=_all_dbs 2>&1 1>& couchdb_exporter.log < /dev/null & | ||
| #sudo cp /etc/secrets/$fname /data/srv/current/auth/$srv/$fname | ||
| #sudo chown $USER.$USER /data/srv/current/auth/$srv/$fname |
There was a problem hiding this comment.
Why secrets are removed? I think it is needed to be able to query CouchDB and collect the metrics.
…tallation candidate and PEP 668 error which prevents installing external (Python packages from pip) on Debian system
3 participants
This PR upgrades: