Subtask aded in detailedView

[Nik-Sch]

As mentioned in #443, I made some changes to the PR #469 including quicker adding/checking/deleting of subtasks

[dmfs]

First of all, thanks for your efforts. I appreciate that. I really like the idea of using quick add to add subtasks.
Here are a few thinks I'd like to get sorted before merging your changes

• I've rebased the original subtasks PR on the current master, you might want to rebase again
• I still want to apply a few more changes to the original PR, in particular support for subtasks should be specified by the task model, so we can support models which don't support subtasks
• I want to add some unit tests for the opentaskspal stuff
• I'm going to merge the original PR in smaller chunks

I hope to get this sorted over the holidays. In the meantime I have only a few comments on your PR.

[dmfs]

I'd like to keep this delay a bit longer so new users will notice the confirmation. Please note that the actual delay gets shorter with every confirmation shown.

[Nik-Sch]

Oh, I did not notice that, that's fine

[dmfs]

The custom QueryRowSetSorting is not necessary. You can apply the Sorted decorator to view giving you the same result. Check this out:

 super(
    new QueryRowSet<>(
        new Sorted<>(Tasks.STATUS + ", " + Tasks.TITLE, view),
        projection,
        new ReferringTo<>(Tasks.PARENT_ID, parentTask)));

[Nik-Sch]

Uh, that's awesome, thank you, I will adjust these changes tomorrow

[Nik-Sch]

I rebased from the original PR #469, included your suggestions and have a few further ideas/bugs:

1. Sometimes the subtasks view is loaded twice (see image). I don't really grasp why this could happen, maybe you have an idea.
2. Maybe the finished subtasks or even the percentage of subtasks should influence the parent's completed percentage, shouldn't it? Currently this happens with the markdown checkboxes, I don't know a good way to integrate both. Maybe one could average both, the "description percentages" and the "subtasks percentages" and if both are >0 average them for the parent's percentage and if only one is >0 take that one.
3. Another idea I had was to show the amount of subtasks a task has in the ListView but I was unsure about how to integrate it without overloading the list

[dmfs]

Please see my comments regarding your points:

1. That's one of the reasons why the original PR needs some more work
2. I'd leave that to a separate story. This can easily get complicated. For instance, in project management or software development it's common that (sub-)tasks have different "weights" (e.g. story points).
3. Let's leave that to a separate story as well. This might need some support from the provider, e.g. we count the number of subtasks upon insert, so we don't need to do that every time when we show a task. Once we drop ExpandableListView and switch to a RecyclerView we could consider allowing to expand subtasks in the list.

I'd also like to reconsider deleting subtasks when deleting the parent. This may not always be the best choice. It might be better to ask the user whether subtasks should be kept and converted to "top-level" tasks or if they should be deleted too.

[Nik-Sch]

Ok, all of your points sound reasonable. Is there something I could further do?