Add provider operations data auto-correction to set timezone to null …#634
Open
lemonboston wants to merge 1 commit into
Open
Add provider operations data auto-correction to set timezone to null …#634lemonboston wants to merge 1 commit into
lemonboston wants to merge 1 commit into
Conversation
…for all-day tasks. #601
lemonboston
force-pushed
the
provider/601-allday-timezone
branch
from
57af484 to
87ef4d3
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…for all-day tasks. #601
@dmfs Note that I haven't reviewed the
FieldAdapters from this timzeonenullfor all-day date-times point of view, just peeked into them and saw they contain a lot of logic. Since refactoring allDateTimeconversions is already planned and I have already started part of that on the branch of #467, I thought we can do that as part of them.Unless there is a chance of exception of incorrect behavior in them because of these changes, tell me if you think that that is the case.