Skip to content

Use py::type::handle_of instead of obj.get_type #4

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
FlyingSamson wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Use py::type::handle_of instead of obj.get_type #4

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions include/swigbind11/swigbind11.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@ inline auto split_python_type_name(std::string_view type_name) -> std::tuple<std
inline auto extract_swig_object(py::handle obj, std::string_view type_name) {
auto [module_name, class_name] = split_python_type_name(type_name);
const auto python_type = py::module_::import(module_name.c_str()).attr(class_name.c_str());
if (!obj.get_type().is(python_type)) {
if (!py::type::of(obj).is(python_type)) {
throw py::cast_error{"got an unexpected type: " + py::str(py::type::of(obj)).cast<std::string>() + " instead of " +
py::str(python_type).cast<std::string>()};
}
Expand Down Expand Up @@ -110,7 +110,7 @@ auto py_swig_cast(std::shared_ptr<T> src, std::string_view python_type_name) ->
/* NOLINTNEXTLINE(cppcoreguidelines-pro-type-reinterpret-cast) */
obj.attr("_swigbind11_shared_ptr") = reinterpret_cast<std::ptrdiff_t>(swigbind11_shared_ptr);
/* monkeypatch the SWIG type with a custom deleter */
py::handle swig_type = obj.get_type();
py::handle swig_type = py::type::of(obj);
if (!py::hasattr(swig_type, "__del__")) {
swig_type.attr("__del__") = py::cpp_function(
[](py::object self /* NOLINT(performance-unnecessary-value-param) */) {
Expand Down