Implement getTargetInfo OSXVersion and FreeBSDVersion#22986
Implement getTargetInfo OSXVersion and FreeBSDVersion#22986ibuclaw wants to merge 1 commit intodlang:masterfrom
Conversation
|
Thanks for your pull request, @ibuclaw! Bugzilla referencesYour PR doesn't reference any Bugzilla issue. If your PR contains non-trivial changes, please reference a Bugzilla issue or create a manual changelog. Testing this PR locallyIf you don't have a local development environment setup, you can use Digger to test this PR: dub run digger -- build "master + dmd#22986" |
ibuclaw
force-pushed
the
target_info_version
branch
from
055453d to
1fe73dc
Compare
|
@jmdavis you might be interesed in reviewing. |
thewilsonator
left a comment
thewilsonator
left a comment
There was a problem hiding this comment.
Tests for CET? Also what is CET?
| // Infer from -target= os version (i.e: freebsd13) | ||
| if (osMajor) | ||
| return osVersion(osMajor * 1_00_000); |
There was a problem hiding this comment.
freebsd13.2 is also a valid triplet but the implementation in dmd to parse this ignores the minor version number.
Perhaps that should be fixed, as the same applies to darwin triplets too (though darwin19.1 and darwin20.1 might have two subtly different meanings between old and new macos versioning schemes)
What are you talking about? Intel CET is just their acronym for shadow stacks and indirect branch tracking. |
ibuclaw
force-pushed
the
target_info_version
branch
3 times, most recently
from
ccbe862 to
b60301c
Compare
ibuclaw
force-pushed
the
target_info_version
branch
from
b60301c to
8faed57
Compare
3 participants
POC trait for dealing with vagary of FreeBSD and OSX versions.
DMD is a bit involved to pry out this information as it tries to be a cross-to-any compiler in a single binary.
GDC already has this information baked in its back-end, either because it only supports one OS version per compiler (as is the case with FreeBSD), or it's handled by a command-line option (
-mmacosx-version-min=on OSX).